bug#53874: Patch: make set-fill-column show the current fill-column

bug#53874: Patch: make set-fill-column show the current fill-column

[Antoine Levitt]

[I posted this on emacs-devel but apparently patches should go to
bug-gnu-emacs so here goes]

I recently used set-fill-column again after years of neglect, and I
remember being mystified by what it did before; I think this is because
I misunderstood the word "default" (I understood it as "the default
setting of fill-column" whereas emacs meant "the thing that will be if
you just press RET"). I think changing the prompt would go a long way
towards making it more accessible to new users, and be more informative
for long-time emacsers as well. Removing the "default" part is tricky
because it's customizable (via minibuffer-default-prompt-format) and
used in several functions, but something like "Set fill-column to
(default 60, currently 80)" looks like a good compromise. Here is a
simple patch doing this.

diff --git a/lisp/simple.el b/lisp/simple.el
index c878fda..b7986ed 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -7903,7 +7903,14 @@ set-fill-column
              ;; We used to use current-column silently, but C-x f is too easily
              ;; typed as a typo for C-x C-f, so we turned it into an error and
              ;; now an interactive prompt.
-             (read-number "Set fill-column to: " (current-column)))))
+             (let ((prompt (concat "Set fill-column to"
+                                   (format minibuffer-default-prompt-format
+                                           (concat (number-to-string (current-column))
+                                                   ", currently "
+                                                   (number-to-string fill-column)))
+                                   ": "))
+                   (minibuffer-default-prompt-format ""))
+               (read-number prompt (current-column))))))
   (if (consp arg)
       (setq arg (current-column)))
   (if (not (integerp arg))

bug#53874: Patch: make set-fill-column show the current fill-column

[Lars Ingebrigtsen]

Antoine Levitt <antoine.levitt@gmail.com> writes:

> +             (let ((prompt (concat "Set fill-column to"
> +                                   (format minibuffer-default-prompt-format
> +                                           (concat (number-to-string (current-column))
> +                                                   ", currently "
> +                                                   (number-to-string fill-column)))
> +                                   ": "))
> +                   (minibuffer-default-prompt-format ""))

Instead of doing it this way, I think it might make more sense to just
change the prompt to "Change fill-column from %s to:" instead?  People
may have set minibuffer-default-prompt-format to something weird.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#53874: Patch: make set-fill-column show the current fill-column

[Antoine Levitt]

> Instead of doing it this way, I think it might make more sense to just
> change the prompt to "Change fill-column from %s to:" instead?  People
> may have set minibuffer-default-prompt-format to something weird.

Good idea and much simpler than what I did ! Here's the patch.

diff --git a/lisp/simple.el b/lisp/simple.el
index dd48039..247f68d 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -8258,7 +8258,7 @@ set-fill-column
              ;; We used to use current-column silently, but C-x f is too easily
              ;; typed as a typo for C-x C-f, so we turned it into an error and
              ;; now an interactive prompt.
-             (read-number "Set fill-column to: " (current-column)))))
+             (read-number (format "Change fill-column from %s to: " fill-column) (current-column)))))
   (if (consp arg)
       (setq arg (current-column)))
   (if (not (integerp arg))

bug#53874: Patch: make set-fill-column show the current fill-column

[Lars Ingebrigtsen]

Antoine Levitt <antoine.levitt@gmail.com> writes:

> Good idea and much simpler than what I did ! Here's the patch.

Thanks; pushed to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no