bug#61452: [PATCH] ; * src/textconv.c (textconv_query): Add empty statement

bug#61452: [PATCH] ; * src/textconv.c (textconv_query): Add empty statement

[Philip Kaludercic]

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

Tags: patch

X-Debbugs-CC: Po Lu <luangruo@yahoo.com>

My GCC gives me this error

--8<---------------cut here---------------start------------->8---
textconv.c: In function ‘textconv_query’:
textconv.c:281:5: error: label at end of compound statement
  281 |     default:
      |     ^~~~~~~
--8<---------------cut here---------------end--------------->8---

$ gcc --version
gcc (Debian 10.2.1-6) 10.2.1 20210110
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

It appears it doesn't want a "default" at the end of a block.  Adding a
semicolon fixes this.

In GNU Emacs 30.0.50 (build 5, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw scroll bars) of 2023-01-30 built on icterid
Repository revision: e19b91f946a99aa812a21bbeff654569bad945d2
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure --with-imagemagick --with-x-toolkit=lucid
 --with-native-compilation=aot'


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-src-textconv.c-textconv_query-Add-empty-statement.patch --]
[-- Type: text/patch, Size: 601 bytes --]

From 9dda7a64ea9e4d1140c5919680d3fa436da4f902 Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk@posteo.net>
Date: Sun, 12 Feb 2023 13:32:55 +0100
Subject: [PATCH] ; * src/textconv.c (textconv_query): Add empty statement

---
 src/textconv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/textconv.c b/src/textconv.c
index e91e127b71c..29dc7f7a41d 100644
--- a/src/textconv.c
+++ b/src/textconv.c
@@ -279,6 +279,7 @@ textconv_query (struct frame *f, struct textconv_callback_struct *query)
 	}
 
     default:
+      ;
     }
 
   /* Undo any changes to the excursion.  */
-- 
2.30.2


[-- Attachment #3: Type: text/plain, Size: 23 bytes --]


-- 
Philip Kaludercic

bug#61452: [PATCH] ; * src/textconv.c (textconv_query): Add empty statement

[Philip Kaludercic]

Philip Kaludercic <philipk@posteo.net> writes:

> Tags: patch
>
> X-Debbugs-CC: Po Lu <luangruo@yahoo.com>
>
> My GCC gives me this error
>
> textconv.c: In function ‘textconv_query’:
> textconv.c:281:5: error: label at end of compound statement
>   281 |     default:
>       |     ^~~~~~~

A similar patch has already been applied, so I am closing this report.

> $ gcc --version
> gcc (Debian 10.2.1-6) 10.2.1 20210110
> Copyright (C) 2020 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> It appears it doesn't want a "default" at the end of a block.  Adding a
> semicolon fixes this.
>
> In GNU Emacs 30.0.50 (build 5, x86_64-pc-linux-gnu, X toolkit, cairo
>  version 1.16.0, Xaw scroll bars) of 2023-01-30 built on icterid
> Repository revision: e19b91f946a99aa812a21bbeff654569bad945d2
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
> System Description: Debian GNU/Linux 11 (bullseye)
>
> Configured using:
>  'configure --with-imagemagick --with-x-toolkit=lucid
>  --with-native-compilation=aot'

-- 
Philip Kaludercic