From: Michael Albinus <michael.albinus@gmx.de>
To: Haiwei Zhou <highfly22@gmail.com>
Cc: 61341-done@debbugs.gnu.org
Subject: bug#61341: Tramp process truncate messages to 4096 bytes
Date: Fri, 17 Feb 2023 10:27:16 +0100 [thread overview]
Message-ID: <874jrk8wwb.fsf@gmx.de> (raw)
In-Reply-To: <CABLXuO-V8G1FVO4ubqXrzcDHE+MHe-2niPHZHpbd1LfYRi_9=Q@mail.gmail.com> (Haiwei Zhou's message of "Tue, 7 Feb 2023 11:36:49 +0800")
Version: 29.2
Haiwei Zhou <highfly22@gmail.com> writes:
> Hi,
Hi,
> According to this link, Linux terminals truncated messages to 4096
> bytes under the tty canonical mode. To fix this issue, the following
> patch will help. I tested on emacs 28.2 with tramp 2.5.3.
>
> --- tramp-sh.el.orig 2022-05-12 19:59:16.000000000 +0800
> +++ tramp-sh.el 2023-01-28 11:14:40.371519390 +0800
> @@ -2959,7 +2959,7 @@
> ;; macOS, see Bug#50748.
> (when (and (memq connection-type '(nil pipe))
> (not (tramp-check-remote-uname v "Darwin")))
> - (tramp-send-command v "stty -icrnl"))
> + (tramp-send-command v "stty -icrnl -icanon"))
> ;; `tramp-maybe-open-connection' and
> ;; `tramp-send-command-and-read' could have
> ;; trashed the connection buffer. Remove this.
In general, your patch looks good. Since I don't use lsp-mode I cannot
check it there, but I trust you that it helps.
However, two enhancements must be done. First, it shall be applied for
remote macOS hosts as well. And secondly, when setting -icanon, one must
also set min and time.
Finally, I've changed this to
--8<---------------cut here---------------start------------->8---
(when (memq connection-type '(nil pipe))
(if (tramp-check-remote-uname v "Darwin")
(tramp-send-command
v "stty -icanon min 1 time 0")
(tramp-send-command
v "stty -icrnl -icanon min 1 time 0")))
--8<---------------cut here---------------end--------------->8---
Pushed to the Emacs master branch. This patch will be contained also in
Tramp 2.6.0.2, scheduled for relase later this month on GNU ELPA.
Closing the bug.
> Thanks,
> Haiwei
Best regards, Michael.
prev parent reply other threads:[~2023-02-17 9:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 3:36 bug#61341: Tramp process truncate messages to 4096 bytes Haiwei Zhou
2023-02-17 9:27 ` Michael Albinus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jrk8wwb.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=61341-done@debbugs.gnu.org \
--cc=highfly22@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).