From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#61341: Tramp process truncate messages to 4096 bytes Date: Fri, 17 Feb 2023 10:27:16 +0100 Message-ID: <874jrk8wwb.fsf@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17270"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61341-done@debbugs.gnu.org To: Haiwei Zhou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 17 10:28:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSx2Y-0004JX-BG for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Feb 2023 10:28:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSx2E-0000Oh-Jw; Fri, 17 Feb 2023 04:28:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSx2B-0000OJ-BS for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 04:28:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSx2A-00060Y-Q5 for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 04:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSx2A-0008KS-7v for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 04:28:02 -0500 Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Feb 2023 09:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 61341 X-GNU-PR-Package: emacs Mail-Followup-To: 61341@debbugs.gnu.org, michael.albinus@gmx.de, highfly22@gmail.com Original-Received: via spool by 61341-done@debbugs.gnu.org id=D61341.167662604531966 (code D ref 61341); Fri, 17 Feb 2023 09:28:01 +0000 Original-Received: (at 61341-done) by debbugs.gnu.org; 17 Feb 2023 09:27:25 +0000 Original-Received: from localhost ([127.0.0.1]:38490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSx1Z-0008JV-C9 for submit@debbugs.gnu.org; Fri, 17 Feb 2023 04:27:25 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:60003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSx1X-0008JI-Ua for 61341-done@debbugs.gnu.org; Fri, 17 Feb 2023 04:27:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1676626038; i=michael.albinus@gmx.de; bh=k87P/UVAld3/SlETWWHIFFnYXysByvxIAoPNoruE6/U=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=ohYfSYewqN3yS82crC9LdyVz0xnpxnrpQ4qSB30HatMhexOhUmOK3mR/xe2x3tUnX t6lBz6JJ9HbX0zp07L9bPLmErAmOYlWyUKld2RGTPjEvmVmnfhefiM2fn+cyS5ck9P jrn3aUGUVETjqDXndcn1dyzl8kUZxMiy4gyO+0HrTGZfmBAkJOcqOxEVEQqh8tW5vb coIFy2gENEMP2mgyBhHQbC+qjFtqYWQbmLXFZUgqG24Y1wsokRkBxclJZgsOV/lIOf +US4nIoJ12We2L2/FC8c9AID2xyZ3YpPlnFx+ArKogAE0wWSgZN0Bab8QkoLn3oEMH logTAZm/NRU8w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.22]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1My36T-1ocVxK1NR1-00zZfG; Fri, 17 Feb 2023 10:27:17 +0100 In-Reply-To: (Haiwei Zhou's message of "Tue, 7 Feb 2023 11:36:49 +0800") X-Provags-ID: V03:K1:RdsGGuqn2iTurItUDxQp1fokW0JD578KrOm5ALueFZsCU3ImBQf 8p0S/9yQl25UH8f9nbuk/USEtTvoDdqzpyMpznPCN774CQJ1vVtFIhucEHLIvplsXxffkFC O4a5Oehj+R/zRfYYdT1WnQ5zjf4YPdOYSlHZ9xzWyQibXLZmF1DfqjI0UxEMj5ZSll+7m1J 48Ibl1rEl9txiZ6s3mhOg== UI-OutboundReport: notjunk:1;M01:P0:Xly+d0glrug=;7W/eHZur2nZQD1wjnhhxhcY3fcg GlLrI0Vh4Yux9wJvc13A40BXgAzqWmY0CEbENcRYXm6DuHS6+WLayG89kMfNtdq07pPZJRzyL tB9MA+i+qZRiMs/wfOcvYWO07fty5E0/9skbCOwJsz8AsLjeofb2HIAHe7yIspLSQL0PJ3Z8S naKOekQu+4BAQVIy1g6xiD8xjKHo/nAkmO6PMW/83ab/EU0M+dCqIq06eZpVj8XKgkQ0pmkiT N0NkjLtKPHQFycDodHqUg045Dt0RGC2Cms4736QzPxyOdXEwfZdQPvYxQzj2/tVsEsSFOj5jF R/+a+g/1oMIn0ygukDS9JsxX3hIZmy7pc7jnIbUR7Z4MdLQg2eZI4IeSxo4cWUkcpERBYXeNj ueo9pRKbYfvOatPUIUdgIgV8HYNRh8PwnWQd3i/foWlFtE+xpKlq/Qpdl5+1spm80owR/5w3T rt+Hf3v7H2mWodURtazn2qRUOrjxVbj6Kg+dpl1iOIcPzZKsYAYKzrAS4FKZyXeqYkBS2SyAy WqS4VkGyHdXzm+RWzzZNsgELCopkRWQk9bhluyBOq0e82i9qRx5xn08i691aS/WTsYpPQ9Qht S5JefmZ514ZYb70r6IhkG2BFL0cWJsxaE5pFv8csi96x8bo0VERwD+AFhrp0rpQ1Vol3zLUyz SEoUKt7NcOI7MJDKgVplO2sSrc2qXunYLncVJbNQnHHt+Kv2aZ80FspT9y1gTjqPIwYaC7T6D mKxKA9h7kHsBUlEJxt5KXcRi7/LH41+9hCidsE1GJih4x4iHB711dLd8Nizrn0eUS4DKP0Ki X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255866 Archived-At: Version: 29.2 Haiwei Zhou writes: > Hi, Hi, > According to this link, Linux terminals truncated messages to 4096 > bytes under the tty canonical mode. To fix this issue, the following > patch will help. I tested on emacs 28.2 with tramp 2.5.3. > > --- tramp-sh.el.orig 2022-05-12 19:59:16.000000000 +0800 > +++ tramp-sh.el 2023-01-28 11:14:40.371519390 +0800 > @@ -2959,7 +2959,7 @@ > ;; macOS, see Bug#50748. > (when (and (memq connection-type '(nil pipe)) > (not (tramp-check-remote-uname v "Darwin"))) > - (tramp-send-command v "stty -icrnl")) > + (tramp-send-command v "stty -icrnl -icanon")) > ;; `tramp-maybe-open-connection' and > ;; `tramp-send-command-and-read' could have > ;; trashed the connection buffer. Remove this. In general, your patch looks good. Since I don't use lsp-mode I cannot check it there, but I trust you that it helps. However, two enhancements must be done. First, it shall be applied for remote macOS hosts as well. And secondly, when setting -icanon, one must also set min and time. Finally, I've changed this to --8<---------------cut here---------------start------------->8--- (when (memq connection-type '(nil pipe)) (if (tramp-check-remote-uname v "Darwin") (tramp-send-command v "stty -icanon min 1 time 0") (tramp-send-command v "stty -icrnl -icanon min 1 time 0"))) --8<---------------cut here---------------end--------------->8--- Pushed to the Emacs master branch. This patch will be contained also in Tramp 2.6.0.2, scheduled for relase later this month on GNU ELPA. Closing the bug. > Thanks, > Haiwei Best regards, Michael.