unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: john muhl via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: Wilhelm H Kirschbaum <wkirschbaum@gmail.com>, 66183@debbugs.gnu.org
Subject: bug#66183: elixir-ts-mode test failure
Date: Mon, 25 Sep 2023 11:01:57 -0500	[thread overview]
Message-ID: <874jji3whk.fsf@pub.pink> (raw)
In-Reply-To: <B325241F-2BC4-4518-A957-DC2397E3CE2E@gmail.com>

Yuan Fu <casouri@gmail.com> writes:

>> On Sep 24, 2023, at 9:53 AM, john muhl via Bug reports for GNU
>> Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org>
>> wrote:
>> 
>> The change in 5cba5ee8905 caused an elixir test to start failing. The
>> white space at the start of the test is now in a heex range so pressing
>> tab there matches a heex rule instead of the elixir one. Moving the
>> dummy range to the end fixes the test.
>
> Thank you. I’ll make sure to remember also running elixir tests when I
> make a change.
>
> I looked around and found elixir-mode’s language-at-point function
> works in a way that isn’t what tree-sitter functions expect.
> Tree-sitter functions expect the major mode to derive language at
> point by querying the host language and do some pattern matching,
> rather than using language parser’s range. I took a quick look at
> elixir’s grammar and came up with this version for a POC. You probably
> need to adjust it but the idea is there.

Thanks for checking. Actually I was just looking at why the tests were
failing but now see that I forgot to include the elixir mode maintainer.

> With the new language-at-point definition, treesit-language-at can
> return the correct language, and the test passes again.

Wilhelm could you have a look?





  reply	other threads:[~2023-09-25 16:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-24 16:53 bug#66183: elixir-ts-mode test failure john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-25  3:12 ` Yuan Fu
2023-09-25 16:01   ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-09-26  6:18     ` Wilhelm Kirschbaum
2023-09-26 16:30   ` Wilhelm Kirschbaum
2023-09-26 18:00     ` Yuan Fu
2023-09-26 20:26       ` Wilhelm Kirschbaum
2023-09-27  6:46         ` Yuan Fu
2023-09-27  7:17           ` Wilhelm Kirschbaum
2023-09-29 11:14       ` Eli Zaretskii
2023-10-05  7:18         ` Eli Zaretskii
2023-10-07  8:44           ` Wilhelm Kirschbaum
2023-10-07  9:05             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jji3whk.fsf@pub.pink \
    --to=bug-gnu-emacs@gnu.org \
    --cc=66183@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=jm@pub.pink \
    --cc=wkirschbaum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).