From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: john muhl via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66183: elixir-ts-mode test failure Date: Mon, 25 Sep 2023 11:01:57 -0500 Message-ID: <874jji3whk.fsf@pub.pink> References: <87fs33wiki.fsf@pub.pink> Reply-To: john muhl Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27472"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Wilhelm H Kirschbaum , 66183@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 25 21:06:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkquH-0006vu-1k for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Sep 2023 21:06:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkqtz-0000xC-Kl; Mon, 25 Sep 2023 15:05:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkqty-0000x3-Jl for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 15:05:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkqty-0006fK-Bc for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 15:05:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qkquA-0002Nc-BK for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 15:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Sep 2023 19:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66183 X-GNU-PR-Package: emacs Original-Received: via spool by 66183-submit@debbugs.gnu.org id=B66183.16956687039064 (code B ref 66183); Mon, 25 Sep 2023 19:06:02 +0000 Original-Received: (at 66183) by debbugs.gnu.org; 25 Sep 2023 19:05:03 +0000 Original-Received: from localhost ([127.0.0.1]:46679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkqtD-0002M7-1c for submit@debbugs.gnu.org; Mon, 25 Sep 2023 15:05:03 -0400 Original-Received: from out-197.mta1.migadu.com ([95.215.58.197]:23765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkqt7-0002Lb-Qv for 66183@debbugs.gnu.org; Mon, 25 Sep 2023 15:05:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1695668684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0WaUd6uXqq/zOOf9rMR4ii3pn8EdIHkHJ6IjGkn2hH0=; b=A1PBj0f++Q8u7+qii/ZszuIBFllR0emG7b5qjjSOUH/nxpIsWGYI227C/5RYRroW8RC7R5 sGM6SmcDkKi437TLBgdmOeMeY8O8SBHbyK5Jo6YMV2YZvqwpjelIGFlRwlR7TJff51+3NG F4KOjklzj5exSMWeHTMNPPRFKUPKFB0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271350 Archived-At: Yuan Fu writes: >> On Sep 24, 2023, at 9:53 AM, john muhl via Bug reports for GNU >> Emacs, the Swiss army knife of text editors >> wrote: >>=20 >> The change in 5cba5ee8905 caused an elixir test to start failing. The >> white space at the start of the test is now in a heex range so pressing >> tab there matches a heex rule instead of the elixir one. Moving the >> dummy range to the end fixes the test. > > Thank you. I=E2=80=99ll make sure to remember also running elixir tests w= hen I > make a change. > > I looked around and found elixir-mode=E2=80=99s language-at-point function > works in a way that isn=E2=80=99t what tree-sitter functions expect. > Tree-sitter functions expect the major mode to derive language at > point by querying the host language and do some pattern matching, > rather than using language parser=E2=80=99s range. I took a quick look at > elixir=E2=80=99s grammar and came up with this version for a POC. You pro= bably > need to adjust it but the idea is there. Thanks for checking. Actually I was just looking at why the tests were failing but now see that I forgot to include the elixir mode maintainer. > With the new language-at-point definition, treesit-language-at can > return the correct language, and the test passes again. Wilhelm could you have a look?