unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#28331: [gnus] Articles loose read status on expiry
@ 2017-09-02 14:30 Nikolaus Rath
  2018-04-11 21:48 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: Nikolaus Rath @ 2017-09-02 14:30 UTC (permalink / raw)
  To: 28331

When marking an article as read and for expiry, and the expiry target is
another group, the article ends up being unread again in the target
group.

An easy fix is to take `gnus-summary-expire-articles' out of
`gnus-summary-prepare-exit-hook', and instead call it explicitly in
`gnus-summary-exit' at a later point.

However, this results in the article not just being marked read in the
target group (as intended), but also still marked for expiry (not
good). I could not figure out how to change that.

I've observed this with the nnimap backend.

Ma Gnus v0.14
GNU Emacs 25.1.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.12)
 of 2017-04-23, modified by Debian

Best,
-Nikolaus

-- 
GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

             »Time flies like an arrow, fruit flies like a Banana.«





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#28331: [gnus] Articles loose read status on expiry
  2017-09-02 14:30 bug#28331: [gnus] Articles loose read status on expiry Nikolaus Rath
@ 2018-04-11 21:48 ` Lars Ingebrigtsen
  2018-04-29 15:13   ` Nikolaus Rath
  0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2018-04-11 21:48 UTC (permalink / raw)
  To: Nikolaus Rath; +Cc: 28331

Nikolaus Rath <Nikolaus@rath.org> writes:

> When marking an article as read and for expiry, and the expiry target is
> another group, the article ends up being unread again in the target
> group.
>
> An easy fix is to take `gnus-summary-expire-articles' out of
> `gnus-summary-prepare-exit-hook', and instead call it explicitly in
> `gnus-summary-exit' at a later point.
>
> However, this results in the article not just being marked read in the
> target group (as intended), but also still marked for expiry (not
> good). I could not figure out how to change that.
>
> I've observed this with the nnimap backend.

I don't use expiry targets, but this sounds like the right solution
(only that the expiry mark should be filtered out).  Could you post the
patch of what you have and I can take a whack at doing the filtering?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#28331: [gnus] Articles loose read status on expiry
  2018-04-11 21:48 ` Lars Ingebrigtsen
@ 2018-04-29 15:13   ` Nikolaus Rath
  0 siblings, 0 replies; 3+ messages in thread
From: Nikolaus Rath @ 2018-04-29 15:13 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 28331

On Apr 11 2018, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Nikolaus Rath <Nikolaus@rath.org> writes:
>
>> When marking an article as read and for expiry, and the expiry target is
>> another group, the article ends up being unread again in the target
>> group.
>>
>> An easy fix is to take `gnus-summary-expire-articles' out of
>> `gnus-summary-prepare-exit-hook', and instead call it explicitly in
>> `gnus-summary-exit' at a later point.
>>
>> However, this results in the article not just being marked read in the
>> target group (as intended), but also still marked for expiry (not
>> good). I could not figure out how to change that.
>>
>> I've observed this with the nnimap backend.
>
> I don't use expiry targets, but this sounds like the right solution
> (only that the expiry mark should be filtered out).  Could you post the
> patch of what you have and I can take a whack at doing the filtering?

"patch" may be exaggerating it a little bit. What I used is

(remove-hook 'gnus-summary-prepare-exit-hook 'gnus-summary-expire-articles)

in my .gnus and

     ;; Remove entries for this group.
     (nnmail-purge-split-history (gnus-group-real-name group))
     ;; Make all changes in this group permanent.
     (unless quit-config
       (gnus-run-hooks 'gnus-exit-group-hook)
       (gnus-summary-update-info))
+    (gnus-summary-expire-articles)
     (gnus-close-group group)
     ;; Make sure where we were, and go to next newsgroup.
     (when (buffer-live-p (get-buffer gnus-group-buffer))
       (set-buffer gnus-group-buffer))
     (unless quit-config

in gnus-summary-exit (gnus-sum.el).



Best,
-Nikolaus

-- 
GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

             »Time flies like an arrow, fruit flies like a Banana.«





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-29 15:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-02 14:30 bug#28331: [gnus] Articles loose read status on expiry Nikolaus Rath
2018-04-11 21:48 ` Lars Ingebrigtsen
2018-04-29 15:13   ` Nikolaus Rath

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).