unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Tom Tromey <tom@tromey.com>
Cc: 18959@debbugs.gnu.org
Subject: bug#18959: 25.0.50; vc-change-log displays "show 2x entries" even when none available
Date: Tue, 19 Jan 2021 17:26:55 +0100	[thread overview]
Message-ID: <8735ywj3jk.fsf@gnus.org> (raw)
In-Reply-To: <87wq79v4cj.fsf@tromey.com> (Tom Tromey's message of "Wed, 05 Nov 2014 12:23:40 -0700")

Tom Tromey <tom@tromey.com> writes:

> I did "C-x v l" on a file with 5 revisions.
> They all appear in *vc-change-log*.
>
> At the bottom I see two buttons:
>
>     Show 2X entries    Show unlimited entries
>
> First, there aren't any more entries, so showing these buttons is
> confusing.  That's somewhat understandable but it would be nice if it
> didn't do that.

(I'm going through old bug reports that unfortunately got no response at
the time.)

It would be -- and this behaviour is still present in Emacs 28.  But I
guess the problem is that we don't really know how many revisions there
are?

On the other hand, we know how many revisions we asked for, and we know
how many we got.  So if we asked for 2000 revisions, and got 5
revisions, then displaying those buttons is probably not necessary?  And
that sounds like something that should be easy to implement.  (If we
asked for 2000 and got 2000, then we don't know, and we'll probably get
a bug report on that, too, but whatevs).

I've now done this on the trunk, and it seem to work OK in my repos.
More testing in non-git VCs would be nice.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-01-19 16:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05 19:23 bug#18959: 25.0.50; vc-change-log displays "show 2x entries" even when none available Tom Tromey
2021-01-19 16:26 ` Lars Ingebrigtsen [this message]
2021-01-19 21:52   ` Tom Tromey
2021-01-20  1:44     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735ywj3jk.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=18959@debbugs.gnu.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).