From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#18959: 25.0.50; vc-change-log displays "show 2x entries" even when none available Date: Tue, 19 Jan 2021 17:26:55 +0100 Message-ID: <8735ywj3jk.fsf@gnus.org> References: <87wq79v4cj.fsf@tromey.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34989"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 18959@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 19 17:29:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1tsc-0008vt-Kj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 17:29:18 +0100 Original-Received: from localhost ([::1]:54200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1tsb-0001xH-LI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 11:29:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1trP-00017T-04 for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 11:28:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39859) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1trO-00061q-Kc for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 11:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l1trO-0006Fp-En for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 11:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jan 2021 16:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18959 X-GNU-PR-Package: emacs Original-Received: via spool by 18959-submit@debbugs.gnu.org id=B18959.161107364023921 (code B ref 18959); Tue, 19 Jan 2021 16:28:02 +0000 Original-Received: (at 18959) by debbugs.gnu.org; 19 Jan 2021 16:27:20 +0000 Original-Received: from localhost ([127.0.0.1]:51402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1tqi-0006Dk-KT for submit@debbugs.gnu.org; Tue, 19 Jan 2021 11:27:20 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:33074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1tqg-0006DY-W3 for 18959@debbugs.gnu.org; Tue, 19 Jan 2021 11:27:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1dS4+ZBpXNRVw0iyyjPJvqysHkZQ9kgJuKyMdcpIbR8=; b=FPp6MRwShGWrZfCPDHde+O/3AL pVhbbvoJRBeyxbndCJsFLXZ+XQrgYtfPKF8JxSc+G9lzec7jFNw1eMjkRhTBeu8Zu3x4d7UCdynKT 93YCUYV6vyhKjYvjeOBn8XJaqVwhQsiX4p2KMHp0iFiFl5E2veFyv7HKOb8mbd6QOdFA=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1tqQ-00024L-Ca; Tue, 19 Jan 2021 17:27:12 +0100 X-Now-Playing: The Matthew Herbert Big Band's _The State Between Us (1)_: "You're Welcome Here" In-Reply-To: <87wq79v4cj.fsf@tromey.com> (Tom Tromey's message of "Wed, 05 Nov 2014 12:23:40 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198179 Archived-At: Tom Tromey writes: > I did "C-x v l" on a file with 5 revisions. > They all appear in *vc-change-log*. > > At the bottom I see two buttons: > > Show 2X entries Show unlimited entries > > First, there aren't any more entries, so showing these buttons is > confusing. That's somewhat understandable but it would be nice if it > didn't do that. (I'm going through old bug reports that unfortunately got no response at the time.) It would be -- and this behaviour is still present in Emacs 28. But I guess the problem is that we don't really know how many revisions there are? On the other hand, we know how many revisions we asked for, and we know how many we got. So if we asked for 2000 revisions, and got 5 revisions, then displaying those buttons is probably not necessary? And that sounds like something that should be easy to implement. (If we asked for 2000 and got 2000, then we don't know, and we'll probably get a bug report on that, too, but whatevs). I've now done this on the trunk, and it seem to work OK in my repos. More testing in non-git VCs would be nice. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no