* bug#46745: 28.0.50; [PATCH] Specify the Emacs version of new vc-dir faces
@ 2021-02-24 9:22 Protesilaos Stavrou
2021-02-24 14:05 ` Basil L. Contovounesios
0 siblings, 1 reply; 3+ messages in thread
From: Protesilaos Stavrou @ 2021-02-24 9:22 UTC (permalink / raw)
To: 46745
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
Dear maintainers,
The attached patch renders explicit the version of Emacs in which the
new vc-dir faces were introduced. I had contributed those faces a few
days ago, but forgot to specify the ':version' property---mea culpa!
All the best,
Protesilaos
--
Protesilaos Stavrou
protesilaos.com
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Specify-the-Emacs-version-of-new-vc-dir-faces.patch --]
[-- Type: text/x-patch, Size: 2486 bytes --]
From 7b5ef8219408a6efe64ed331cde303dd7101e4fd Mon Sep 17 00:00:00 2001
Message-Id: <7b5ef8219408a6efe64ed331cde303dd7101e4fd.1614158325.git.info@protesilaos.com>
From: Protesilaos Stavrou <info@protesilaos.com>
Date: Wed, 24 Feb 2021 11:18:38 +0200
Subject: [PATCH] Specify the Emacs version of new vc-dir faces
* vc-dir.el (vc-dir-header):
(vc-dir-header-value):
(vc-dir-directory):
(vc-dir-file):
(vc-dir-mark-indicator):
(vc-dir-status-warning):
(vc-dir-status-edited):
(vc-dir-status-up-to-date):
(vc-dir-status-ignored): Add version 28.1.
---
lisp/vc/vc-dir.el | 27 ++++++++++++++++++---------
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el
index a416474e16..46fbf44861 100644
--- a/lisp/vc/vc-dir.el
+++ b/lisp/vc/vc-dir.el
@@ -56,39 +56,48 @@ vc-dir-mode-hook
(defface vc-dir-header '((t :inherit font-lock-type-face))
"Face for headers in VC-dir buffers."
- :group 'vc)
+ :group 'vc
+ :version "28.1")
(defface vc-dir-header-value '((t :inherit font-lock-variable-name-face))
"Face for header values in VC-dir buffers."
- :group 'vc)
+ :group 'vc
+ :version "28.1")
(defface vc-dir-directory '((t :inherit font-lock-comment-delimiter-face))
"Face for directories in VC-dir buffers."
- :group 'vc)
+ :group 'vc
+ :version "28.1")
(defface vc-dir-file '((t :inherit font-lock-function-name-face))
"Face for files in VC-dir buffers."
- :group 'vc)
+ :group 'vc
+ :version "28.1")
(defface vc-dir-mark-indicator '((t :inherit font-lock-type-face))
"Face for mark indicators in VC-dir buffers."
- :group 'vc)
+ :group 'vc
+ :version "28.1")
(defface vc-dir-status-warning '((t :inherit font-lock-warning-face))
"Face for warning status in VC-dir buffers."
- :group 'vc)
+ :group 'vc
+ :version "28.1")
(defface vc-dir-status-edited '((t :inherit font-lock-variable-name-face))
"Face for edited status in VC-dir buffers."
- :group 'vc)
+ :group 'vc
+ :version "28.1")
(defface vc-dir-status-up-to-date '((t :inherit font-lock-builtin-face))
"Face for up-to-date status in VC-dir buffers."
- :group 'vc)
+ :group 'vc
+ :version "28.1")
(defface vc-dir-status-ignored '((t :inherit shadow))
"Face for ignored or empty values in VC-dir buffers."
- :group 'vc)
+ :group 'vc
+ :version "28.1")
;; Used to store information for the files displayed in the directory buffer.
;; Each item displayed corresponds to one of these defstructs.
--
2.30.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#46745: 28.0.50; [PATCH] Specify the Emacs version of new vc-dir faces
2021-02-24 9:22 bug#46745: 28.0.50; [PATCH] Specify the Emacs version of new vc-dir faces Protesilaos Stavrou
@ 2021-02-24 14:05 ` Basil L. Contovounesios
2021-02-25 5:54 ` Protesilaos Stavrou
0 siblings, 1 reply; 3+ messages in thread
From: Basil L. Contovounesios @ 2021-02-24 14:05 UTC (permalink / raw)
To: Protesilaos Stavrou; +Cc: 46745-done
tags 46745 fixed
close 46745 28.1
quit
Protesilaos Stavrou <info@protesilaos.com> writes:
> The attached patch renders explicit the version of Emacs in which the
> new vc-dir faces were introduced. I had contributed those faces a few
> days ago, but forgot to specify the ':version' property---mea culpa!
Thanks, and no worries, it happens all the time here ;).
Pushed with a couple of tweaks to the log message to
reference the bug#number and remove redundant colons
(see CONTRIBUTE and (info "(standards) Change Logs")).
Specify the Emacs version of new vc-dir faces
91b37381ea 2021-02-24 13:45:12 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=91b37381eaa8db64965249b5a3a377c51d0afa1b
--
Basil
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#46745: 28.0.50; [PATCH] Specify the Emacs version of new vc-dir faces
2021-02-24 14:05 ` Basil L. Contovounesios
@ 2021-02-25 5:54 ` Protesilaos Stavrou
0 siblings, 0 replies; 3+ messages in thread
From: Protesilaos Stavrou @ 2021-02-25 5:54 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: 46745-done
On 2021-02-24, 14:05 +0000, "Basil L. Contovounesios" <contovob@tcd.ie> wrote:
> tags 46745 fixed
> close 46745 28.1
> quit
>
> Protesilaos Stavrou <info@protesilaos.com> writes:
>
>> The attached patch renders explicit the version of Emacs in which the
>> new vc-dir faces were introduced. I had contributed those faces a few
>> days ago, but forgot to specify the ':version' property---mea culpa!
>
> Thanks, and no worries, it happens all the time here ;).
>
> Pushed with a couple of tweaks to the log message to
> reference the bug#number and remove redundant colons
> (see CONTRIBUTE and (info "(standards) Change Logs")).
>
> Specify the Emacs version of new vc-dir faces
> 91b37381ea 2021-02-24 13:45:12 +0000
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=91b37381eaa8db64965249b5a3a377c51d0afa1b
I see. Thank you! I used 'log-edit-generate-changelog-from-diff' and
gave too much trust to its output...
--
Protesilaos Stavrou
protesilaos.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-25 5:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-24 9:22 bug#46745: 28.0.50; [PATCH] Specify the Emacs version of new vc-dir faces Protesilaos Stavrou
2021-02-24 14:05 ` Basil L. Contovounesios
2021-02-25 5:54 ` Protesilaos Stavrou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).