* bug#49077: 26.3; conf-mode for Java properties files uses incorrect comment syntax
@ 2021-06-17 17:10 Spencer Nelson
2021-06-19 13:33 ` Lars Ingebrigtsen
2022-07-16 12:15 ` Lars Ingebrigtsen
0 siblings, 2 replies; 4+ messages in thread
From: Spencer Nelson @ 2021-06-17 17:10 UTC (permalink / raw)
To: 49077
I noticed today that conf-mode.el's derived mode, conf-javaprop-mode,
isn't configured correctly for Java properties files.
The documenting comment for conf-javaprop-mode says this:
"Conf Mode starter for Java properties files.
Comments start with `#' but are also recognized with `//' or
between `/*' and `*/'.
For details see `conf-mode'. Example:
# Conf mode font-locks this right with \\[conf-javaprop-mode] (Java properties)
// another kind of comment
/* yet another */
But // and /* don't start comments in Java properties files. Java
properties files just have single-line comments starting with #.
Somewhat obscurely, comments can also start with !.
I'm up for submitting a patch to fix this, but it would be my first
contribution to emacs, and I'm a bit intimidated, so I want to check
whether it's reasonable to fix first.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#49077: 26.3; conf-mode for Java properties files uses incorrect comment syntax
2021-06-17 17:10 bug#49077: 26.3; conf-mode for Java properties files uses incorrect comment syntax Spencer Nelson
@ 2021-06-19 13:33 ` Lars Ingebrigtsen
2022-07-16 12:15 ` Lars Ingebrigtsen
1 sibling, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-06-19 13:33 UTC (permalink / raw)
To: Spencer Nelson; +Cc: 49077
Spencer Nelson <swnelson@uw.edu> writes:
> I'm up for submitting a patch to fix this, but it would be my first
> contribution to emacs, and I'm a bit intimidated, so I want to check
> whether it's reasonable to fix first.
Sure, fixing this would be very welcome.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#49077: 26.3; conf-mode for Java properties files uses incorrect comment syntax
2021-06-17 17:10 bug#49077: 26.3; conf-mode for Java properties files uses incorrect comment syntax Spencer Nelson
2021-06-19 13:33 ` Lars Ingebrigtsen
@ 2022-07-16 12:15 ` Lars Ingebrigtsen
2022-08-20 9:54 ` Lars Ingebrigtsen
1 sibling, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2022-07-16 12:15 UTC (permalink / raw)
To: Spencer Nelson; +Cc: 49077
Spencer Nelson <swnelson@uw.edu> writes:
> The documenting comment for conf-javaprop-mode says this:
>
> "Conf Mode starter for Java properties files.
> Comments start with `#' but are also recognized with `//' or
> between `/*' and `*/'.
> For details see `conf-mode'. Example:
>
> # Conf mode font-locks this right with \\[conf-javaprop-mode] (Java properties)
> // another kind of comment
> /* yet another */
>
> But // and /* don't start comments in Java properties files. Java
> properties files just have single-line comments starting with #.
> Somewhat obscurely, comments can also start with !.
I thought this should be easy to fix, but I'm not at all sure where the
font-locking of // and /* */ is coming from. I feel like I've looked at
all the font-lock-* variables, but I can't find anything.
Anybody?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#49077: 26.3; conf-mode for Java properties files uses incorrect comment syntax
2022-07-16 12:15 ` Lars Ingebrigtsen
@ 2022-08-20 9:54 ` Lars Ingebrigtsen
0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2022-08-20 9:54 UTC (permalink / raw)
To: Spencer Nelson; +Cc: 49077
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I thought this should be easy to fix, but I'm not at all sure where the
> font-locking of // and /* */ is coming from. I feel like I've looked at
> all the font-lock-* variables, but I can't find anything.
It was in the syntax property stuff. Now fixed in Emacs 29.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-20 9:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 17:10 bug#49077: 26.3; conf-mode for Java properties files uses incorrect comment syntax Spencer Nelson
2021-06-19 13:33 ` Lars Ingebrigtsen
2022-07-16 12:15 ` Lars Ingebrigtsen
2022-08-20 9:54 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).