From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 49632@debbugs.gnu.org, Brian Leung <leungbk@mailfence.com>
Subject: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map
Date: Sun, 25 Jul 2021 23:53:31 +0300 [thread overview]
Message-ID: <8735s2ru7o.fsf@mail.linkov.net> (raw)
In-Reply-To: <87sg02zz65.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 25 Jul 2021 08:26:58 +0200")
>> OK, I've updated the patch following Juri's suggestions.
>
> Skimming the patch, it looks good to me. Juri, do you have any
> comments?
There is one thing that I don't understand: is the
helper function gud-set-repeat-map-property really needed?
If e.g. the defvar gud-gdb-repeat-map uses such symbols as 'gud-next',
could it put the 'repeat-map' property on the same symbols
with reference to the variable 'map' directly in these defvars?
Then only defvars will be needed, and no changes in gud-gdb, gdb.
next prev parent reply other threads:[~2021-07-25 20:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 3:37 bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map Brian Leung
2021-07-19 13:06 ` Lars Ingebrigtsen
2021-07-19 13:13 ` Eli Zaretskii
2021-07-19 14:57 ` Brian Leung
2021-07-19 16:05 ` Eli Zaretskii
2021-07-19 21:53 ` Juri Linkov
2021-07-19 14:51 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-19 15:37 ` Juri Linkov
2021-07-19 15:52 ` Lars Ingebrigtsen
2021-07-24 3:33 ` Brian Leung
2021-07-25 6:26 ` Lars Ingebrigtsen
2021-07-25 20:53 ` Juri Linkov [this message]
2021-07-25 21:28 ` Brian Leung
2021-07-26 22:48 ` Juri Linkov
2021-07-27 4:09 ` Brian Leung
2021-07-27 6:46 ` Brian Leung
2021-07-27 21:15 ` Juri Linkov
2021-07-28 11:30 ` Eli Zaretskii
2021-07-28 16:23 ` Juri Linkov
2021-07-28 16:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735s2ru7o.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=49632@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=leungbk@mailfence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).