From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map Date: Sun, 25 Jul 2021 23:53:31 +0300 Organization: LINKOV.NET Message-ID: <8735s2ru7o.fsf@mail.linkov.net> References: <89178870.2006793.1626665845848@ichabod.co-bxl> <87eebupi5k.fsf@gnus.org> <343742107.2068902.1626706305280@ichabod.co-bxl> <87k0lml3wt.fsf@mail.linkov.net> <874kcql2r8.fsf@gnus.org> <2097190220.304800.1627097630028@ichabod.co-bxl> <87sg02zz65.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4850"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 49632@debbugs.gnu.org, Brian Leung To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 25 22:59:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7lDa-0001AP-JM for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 22:59:26 +0200 Original-Received: from localhost ([::1]:42694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7lDZ-0007DO-K2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 16:59:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7lDC-0007Ah-LM for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 16:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37949) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7lDC-0001ax-E1 for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 16:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m7lDC-0000se-EH for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 16:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jul 2021 20:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49632-submit@debbugs.gnu.org id=B49632.16272467073324 (code B ref 49632); Sun, 25 Jul 2021 20:59:02 +0000 Original-Received: (at 49632) by debbugs.gnu.org; 25 Jul 2021 20:58:27 +0000 Original-Received: from localhost ([127.0.0.1]:49493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7lCd-0000rT-EF for submit@debbugs.gnu.org; Sun, 25 Jul 2021 16:58:27 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:58781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7lCa-0000qu-9d for 49632@debbugs.gnu.org; Sun, 25 Jul 2021 16:58:24 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id BBFBE60003; Sun, 25 Jul 2021 20:58:16 +0000 (UTC) In-Reply-To: <87sg02zz65.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 25 Jul 2021 08:26:58 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210736 Archived-At: >> OK, I've updated the patch following Juri's suggestions. > > Skimming the patch, it looks good to me. Juri, do you have any > comments? There is one thing that I don't understand: is the helper function gud-set-repeat-map-property really needed? If e.g. the defvar gud-gdb-repeat-map uses such symbols as 'gud-next', could it put the 'repeat-map' property on the same symbols with reference to the variable 'map' directly in these defvars? Then only defvars will be needed, and no changes in gud-gdb, gdb.