unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Matthias Meulien <orontee@gmail.com>
To: 54813@debbugs.gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#54813: 29.0.50; Diff file motion commands skip file mode changes
Date: Sat, 09 Apr 2022 14:41:15 +0200	[thread overview]
Message-ID: <8735immntg.fsf@gmail.com> (raw)
In-Reply-To: <877d7ymou9.fsf@gmail.com> (Matthias Meulien's message of "Sat, 09 Apr 2022 14:19:10 +0200")

Matthias Meulien <orontee@gmail.com> writes:

> Analysis: Git diff shows file mode changes when the execution bit is
> affected by the change. There may be no file content change, thus no
> lines starting with --- or +++. In such case the regexp defined by
> `diff-file-header-re' doesn't match which explains the bug.

Note that `diff-goto-source' is based on "hunk headers" search and fails
to open the README file from the diff.  Not sure it should be considered
as a bug...





      reply	other threads:[~2022-04-09 12:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-09 12:19 bug#54813: 29.0.50; Diff file motion commands skip file mode changes Matthias Meulien
2022-04-09 12:41 ` Matthias Meulien [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735immntg.fsf@gmail.com \
    --to=orontee@gmail.com \
    --cc=54813@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).