From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#54813: 29.0.50; Diff file motion commands skip file mode changes Date: Sat, 09 Apr 2022 14:41:15 +0200 Message-ID: <8735immntg.fsf@gmail.com> References: <877d7ymou9.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30561"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stefan Monnier To: 54813@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 09 14:43:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndAR3-0007o8-Bo for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Apr 2022 14:43:25 +0200 Original-Received: from localhost ([::1]:50322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndAR2-0007Ty-1a for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Apr 2022 08:43:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndAPn-0007Kz-9p for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2022 08:42:17 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43056) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ndAPh-0001lh-Nt for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2022 08:42:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ndAPh-0007kW-M5 for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2022 08:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Apr 2022 12:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54813 X-GNU-PR-Package: emacs Original-Received: via spool by 54813-submit@debbugs.gnu.org id=B54813.164950808529742 (code B ref 54813); Sat, 09 Apr 2022 12:42:01 +0000 Original-Received: (at 54813) by debbugs.gnu.org; 9 Apr 2022 12:41:25 +0000 Original-Received: from localhost ([127.0.0.1]:36953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndAP7-0007je-Dx for submit@debbugs.gnu.org; Sat, 09 Apr 2022 08:41:25 -0400 Original-Received: from mail-wm1-f41.google.com ([209.85.128.41]:40720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndAP5-0007jO-NM for 54813@debbugs.gnu.org; Sat, 09 Apr 2022 08:41:24 -0400 Original-Received: by mail-wm1-f41.google.com with SMTP id v64-20020a1cac43000000b0038cfd1b3a6dso9249028wme.5 for <54813@debbugs.gnu.org>; Sat, 09 Apr 2022 05:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wrvU0s2sR8uNHW9SCTpXWzY0Aqb+/0fLHMF6JDpyhXc=; b=gRNq0Hnzq/dmSXLR1yXFNLhbDWsMIOT4IaZlKHt043MdRaxoAqxs1TlQcCsNEI91h1 qxSm63HmRQnxaS5fG/gI3fLuNw9RfLAO9TgNWXAv53P6Hg1ou2KzllKtjaYKb2xDFO1g jWvwz0RvyYqLMA4VNTxjFN2AYCKMNFMzXGzpPOGr39149/P7d5QN+EO8fnJqDVEIjMyA irJ35503GORGfHCP+rWZF6xqOE0HeHLGZuaR2SHjqYZK0evMkewmOay3pjf/CNok1N0M BctVS2OWM6fNrWeVhl339YQBIltyCE4oMbPn/BbLtrD5pbaRVI2SCylkLxzfLiTzxuYu fzhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wrvU0s2sR8uNHW9SCTpXWzY0Aqb+/0fLHMF6JDpyhXc=; b=wi4SlGxGuTEdoQja1JILk0ki9K1FkcMeO0YlyMaMeh8flRmrpXuNpqzHLIdtV2fNJ8 FwZHAHxYtHMaDhZ9XWF4LhhbzR42eqINN0OlOp/vktwtCi24ARacMnwUCcNotj5Bfp+j RDquQzRDCWBXOQC9BHOsVC5xOM8AtYwc8XPZAN0t+NA8rhOMqtNGsNV6EimQii8NGczQ dk/P3qnjwbggyHfhPrU7CdhzmTLmuJeMJqxdQAuI6gOrsyMo+FWjEtiEOCIImjHOu5kD IgKp4gFswLOW+fTSLe+xWhBPFqLYWZVTQAtKUSGrKRqLkan+ptQumnc9onp1OtZZZOtY pJig== X-Gm-Message-State: AOAM530uoQOn8mdlYmIJv1AheR99Ggh1dFrT25A1sI5z1VV6a8E99Zen Ml4+YLb5rp5AA+69/mXyQS0= X-Google-Smtp-Source: ABdhPJyuRsQ1RJaSvVRD3aGoP5j2ww8uYZNgmq6ul7u9mf+68/AUCIKPNDc+SB+gRTzDdI4BjCNbiw== X-Received: by 2002:a05:600c:4fd4:b0:38c:cc3f:ac01 with SMTP id o20-20020a05600c4fd400b0038ccc3fac01mr21319912wmq.206.1649508077570; Sat, 09 Apr 2022 05:41:17 -0700 (PDT) Original-Received: from carbon.localdomain ([2a01:e0a:245:c850:98f5:429a:aa8e:95bb]) by smtp.gmail.com with ESMTPSA id c24-20020a7bc018000000b0038a18068cf5sm12260964wmb.15.2022.04.09.05.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Apr 2022 05:41:17 -0700 (PDT) In-Reply-To: <877d7ymou9.fsf@gmail.com> (Matthias Meulien's message of "Sat, 09 Apr 2022 14:19:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229615 Archived-At: Matthias Meulien writes: > Analysis: Git diff shows file mode changes when the execution bit is > affected by the change. There may be no file content change, thus no > lines starting with --- or +++. In such case the regexp defined by > `diff-file-header-re' doesn't match which explains the bug. Note that `diff-goto-source' is based on "hunk headers" search and fails to open the README file from the diff. Not sure it should be considered as a bug...