unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#37087: indent-for-tab-command not ready for GNUmakefile mode
@ 2019-08-19 18:02 積丹尼 Dan Jacobson
  2019-10-30 11:14 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: 積丹尼 Dan Jacobson @ 2019-08-19 18:02 UTC (permalink / raw)
  To: 37087

TAB (translated from <tab>) runs the command indent-for-tab-command

However it ruins Makefiles.

C-x h TAB wipes out all indentation.

I don't know what it should do. All I know is it shouldn't wipe out all
indentation.

emacs-version "26.1"





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#37087: indent-for-tab-command not ready for GNUmakefile mode
  2019-08-19 18:02 bug#37087: indent-for-tab-command not ready for GNUmakefile mode 積丹尼 Dan Jacobson
@ 2019-10-30 11:14 ` Lars Ingebrigtsen
  2019-11-05 23:27   ` 積丹尼 Dan Jacobson
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2019-10-30 11:14 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 37087

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> TAB (translated from <tab>) runs the command indent-for-tab-command
>
> However it ruins Makefiles.
>
> C-x h TAB wipes out all indentation.
>
> I don't know what it should do. All I know is it shouldn't wipe out all
> indentation.

If I try `C-x h TAB' in Emacs 27, it just inserts a TAB character.  Is
there something else needed to reproduce the bug?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#37087: indent-for-tab-command not ready for GNUmakefile mode
  2019-10-30 11:14 ` Lars Ingebrigtsen
@ 2019-11-05 23:27   ` 積丹尼 Dan Jacobson
  2020-08-06 16:30     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: 積丹尼 Dan Jacobson @ 2019-11-05 23:27 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 37087

>>>>> "LI" == Lars Ingebrigtsen <larsi@gnus.org> writes:
LI> 積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

>> TAB (translated from <tab>) runs the command indent-for-tab-command
>> 
>> However it ruins Makefiles.
>> 
>> C-x h TAB wipes out all indentation.
>> 
>> I don't know what it should do. All I know is it shouldn't wipe out all
>> indentation.

LI> If I try `C-x h TAB' in Emacs 27, it just inserts a TAB character.  Is
LI> there something else needed to reproduce the bug?

Yes.
Somebody else's makefile. The bigger the better.
Not an empty makefile.
You are testing on an empty makefile. Don't.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#37087: indent-for-tab-command not ready for GNUmakefile mode
  2019-11-05 23:27   ` 積丹尼 Dan Jacobson
@ 2020-08-06 16:30     ` Lars Ingebrigtsen
  2022-05-03 14:03       ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-08-06 16:30 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 37087

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> LI> If I try `C-x h TAB' in Emacs 27, it just inserts a TAB character.  Is
> LI> there something else needed to reproduce the bug?
>
> Yes.
> Somebody else's makefile. The bigger the better.
> Not an empty makefile.
> You are testing on an empty makefile. Don't.

No, I was testing without transient mark mode -- it has to be on to
reproduce the bug.

So the bug is (with transient-mark-mode): Mark a region (that contains
tabs), and then hit TAB.  It'll remove all the (leading) tabs in the
region, oddly enough.

The bug is still present in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#37087: indent-for-tab-command not ready for GNUmakefile mode
  2020-08-06 16:30     ` Lars Ingebrigtsen
@ 2022-05-03 14:03       ` Lars Ingebrigtsen
  2022-05-16 12:26         ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-03 14:03 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 37087

Lars Ingebrigtsen <larsi@gnus.org> writes:

> So the bug is (with transient-mark-mode): Mark a region (that contains
> tabs), and then hit TAB.  It'll remove all the (leading) tabs in the
> region, oddly enough.
>
> The bug is still present in Emacs 28.

I've now fixed this in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#37087: indent-for-tab-command not ready for GNUmakefile mode
  2022-05-03 14:03       ` Lars Ingebrigtsen
@ 2022-05-16 12:26         ` Lars Ingebrigtsen
  0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-16 12:26 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 37087

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I've now fixed this in Emacs 29.

The change led to bug#55446, so I've reverted the change and reopened
this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-05-16 12:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 18:02 bug#37087: indent-for-tab-command not ready for GNUmakefile mode 積丹尼 Dan Jacobson
2019-10-30 11:14 ` Lars Ingebrigtsen
2019-11-05 23:27   ` 積丹尼 Dan Jacobson
2020-08-06 16:30     ` Lars Ingebrigtsen
2022-05-03 14:03       ` Lars Ingebrigtsen
2022-05-16 12:26         ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).