bug#55967: 29.0.50; [PATCH] Cmd-t on macOS asks for a font using the minibuffer

bug#55967: 29.0.50; [PATCH] Cmd-t on macOS asks for a font using the minibuffer

[Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]


This is a regression from Emacs 28.1.  In Emacs 28.1, Cmd-t is bound to
ns-popup-font-panel, which shows the native macOS font panel.  With the
removal of ns-popup-font-panel, Cmd-t is now bound to set-frame-font.
However, I think the best replacement is menu-set-font, which is what
Options, Set Default Font calls.

I've attached a patch.  Thanks.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Bind-Cmd-t-to-menu-set-font-on-macOS.patch --]
[-- Type: text/x-patch, Size: 1157 bytes --]

From 78a543ae0ece188334356daf003eae6cc7c9359e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= <mardani29@yahoo.es>
Date: Tue, 14 Jun 2022 13:20:59 +0200
Subject: [PATCH] Bind Cmd-t to menu-set-font on macOS

* lisp/term/ns-win.el (global-map): set-frame-font asks for a font
using the minibuffer, but the former ns-popup-font-panel always showed
the graphical font panel on macOS.  To preserve the same behavior,
bind it to menu-set-font, which is also called by Options, Set Default
Font.
---
 lisp/term/ns-win.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el
index 677ebb400e..84c5b087b9 100644
--- a/lisp/term/ns-win.el
+++ b/lisp/term/ns-win.el
@@ -142,7 +142,7 @@ global-map
 (define-key global-map [?\s-p] 'ns-print-buffer)
 (define-key global-map [?\s-q] 'save-buffers-kill-emacs)
 (define-key global-map [?\s-s] 'save-buffer)
-(define-key global-map [?\s-t] 'set-frame-font)
+(define-key global-map [?\s-t] 'menu-set-font)
 (define-key global-map [?\s-u] 'revert-buffer)
 (define-key global-map [?\s-v] 'yank)
 (define-key global-map [?\s-w] 'delete-frame)
-- 
2.34.1

bug#55967: 29.0.50; [PATCH] Cmd-t on macOS asks for a font using the minibuffer

[Lars Ingebrigtsen]

Daniel Martín <mardani29@yahoo.es> writes:

> This is a regression from Emacs 28.1.  In Emacs 28.1, Cmd-t is bound to
> ns-popup-font-panel, which shows the native macOS font panel.  With the
> removal of ns-popup-font-panel, Cmd-t is now bound to set-frame-font.
> However, I think the best replacement is menu-set-font, which is what
> Options, Set Default Font calls.
>
> I've attached a patch.  Thanks.

Thanks; pushed to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no