From: Dieter Deyke <dieter.deyke@gmail.com>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: 58002@debbugs.gnu.org, stefankangas@gmail.com
Subject: bug#58002: 29.1: Sokoban: obsoletion warnings in gamegrid
Date: Thu, 22 Sep 2022 14:29:45 +0200 [thread overview]
Message-ID: <8735cj7ft2.fsf@gmail.com> (raw)
In-Reply-To: <EE6A6AC8-650D-4684-8565-1D3B76FC5211@gmail.com> ("Mattias Engdegård"'s message of "Thu, 22 Sep 2022 12:06:27 +0200")
Mattias Engdegård <mattias.engdegard@gmail.com> writes:
> On Emacs master, starting Sokoban (from GNU ELPA) results in several warnings:
>
>> Warning (gamegrid): Using obsolete XEmacs style "glyph"; convert to an Emacs image-spec instead
>
> which apparently is from
>
>> (defvar sokoban-target-options
>> `(((glyph
>> [xpm :data ,sokoban-target-xpm])
> [...]
>
> where (after some digging) it seems that the vector needs to be
>
> ((:type xpm :data ,sokoban-target-xpm :ascent center)))
>
> somewhat non-intuitively, because of the slightly alarming line
>
>> (find-image data)) ;untested!
>
> in gamegrid.el. Suggested patch attached.
> Is this all correct and as desired? Does it break anything when using old Emacs versions?
Thanks for your efforts, but that patch does not silence the warnings on
my system. It looks like more is needed, but I do not know how to fix
it.
--
Dieter Deyke
mailto:dieter.deyke@gmail.com
Get my Gnupg key:
gpg --keyserver keys.gnupg.net --recv-keys B116EA20
next prev parent reply other threads:[~2022-09-22 12:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 10:06 bug#58002: 29.1: Sokoban: obsoletion warnings in gamegrid Mattias Engdegård
2022-09-22 12:29 ` Dieter Deyke [this message]
2022-09-22 12:39 ` Mattias Engdegård
2022-09-22 12:54 ` Dieter Deyke
2022-09-22 14:01 ` Stefan Kangas
2022-09-23 8:56 ` Mattias Engdegård
2022-11-12 21:11 ` Stefan Kangas
2022-11-13 6:17 ` Dieter Deyke
2022-11-13 13:59 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735cj7ft2.fsf@gmail.com \
--to=dieter.deyke@gmail.com \
--cc=58002@debbugs.gnu.org \
--cc=mattias.engdegard@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).