From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dieter Deyke Newsgroups: gmane.emacs.bugs Subject: bug#58002: 29.1: Sokoban: obsoletion warnings in gamegrid Date: Thu, 22 Sep 2022 14:29:45 +0200 Message-ID: <8735cj7ft2.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8137"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 58002@debbugs.gnu.org, stefankangas@gmail.com To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 22 14:32:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obLNO-0001uA-DT for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Sep 2022 14:32:22 +0200 Original-Received: from localhost ([::1]:39980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1obLNN-0008S4-6S for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Sep 2022 08:32:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obLLB-0007UA-3r for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 08:30:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37477) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1obLL8-00044U-Qj for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 08:30:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1obLL8-0002nf-Kt for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 08:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dieter Deyke Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Sep 2022 12:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58002 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: Emacs Bug Report , Stefan Kangas Original-Received: via spool by submit@debbugs.gnu.org id=B.166384979810733 (code B ref -1); Thu, 22 Sep 2022 12:30:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Sep 2022 12:29:58 +0000 Original-Received: from localhost ([127.0.0.1]:36555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obLL4-0002n3-DI for submit@debbugs.gnu.org; Thu, 22 Sep 2022 08:29:58 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:45840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obLL1-0002mu-Cr for submit@debbugs.gnu.org; Thu, 22 Sep 2022 08:29:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obLL0-0007La-WA for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 08:29:55 -0400 Original-Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:39820) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1obLKv-0003g2-H4 for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 08:29:54 -0400 Original-Received: by mail-ed1-x530.google.com with SMTP id f20so13341183edf.6 for ; Thu, 22 Sep 2022 05:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=avQPqX6MBqaRlnbM9CMlfxwvoINd2YNDcmmVyFxb2Nc=; b=S/Cla0VjExtHtScSIM9bmrhBJFLTzB7jmtvKSbG8KNJA4I4v2HI3V+rvzrRoFAGLC9 vjjWTnoF3cF/clyWXNr/BMNhqINqeRjU6nX+ff2GnW3xlzc+6fq2UuNQ8PXutZjEL1Dn rfS4waj9zeVIJ6QihJZt1oV7rdQCaGW7HERgaCD1m3MvIoKtzpchV9K0ZK5Uf2MiPzdr FNk2gADE4CXhftfeMGWVydmNOb6Dime1/AVao4mZGf2Hv/b+MqYC3U9yNVFyz9ivz860 8Ha9sWvZ0KOA4XIpgXnQQqF+zBLq86ghpLDQHeZAA8goUTKfbwYQkSsX1D4dD0uOtbr8 PgEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date; bh=avQPqX6MBqaRlnbM9CMlfxwvoINd2YNDcmmVyFxb2Nc=; b=gGxHwfFabSbbnykwiM2iiA/vA3RbC4LrLQwblC748d17YNHzu4EZG3m+Sa9GxSkqa8 jkvVCWL2CI7cxUmb7LvCOfckBxmeHto79RMtFdqbi4EKkq4RPiMYVzKFnHONScvSS8bE HDrScgH2cNLX1EIXbwZEKxz6jaO00PcZue9rygS+lNeJTPsYWo6qRFJaSPyDKBpndw/O IVIQe150ac1CGVq/Rw3/Yrzq1aE92LFNhwOIPWtnAAqI/sE+xNJH2WQpuY5GcbbQup33 HMxkQE+6iJrBwqj5fAa7kaddOTJePVfV5KXM/uxbESrIgm1BEA23oSQopF3cvymTCCuy +t2w== X-Gm-Message-State: ACrzQf1VkYHqfHL4jZITrqOrfKHHKrjHbGTIc6P+R2pf+7CqYY8WFSId XCtDxyO6VyNK89Pa8B7XERg3gFVZnMY= X-Google-Smtp-Source: AMsMyM7hkdSCqyDYEMGwvRlMppQOiqwl26od9slBqHu1ubfE3hLK7t46wcCZCX1YURX6pQ5JNukMAw== X-Received: by 2002:a05:6402:40cc:b0:452:697e:da18 with SMTP id z12-20020a05640240cc00b00452697eda18mr2983446edb.288.1663849787046; Thu, 22 Sep 2022 05:29:47 -0700 (PDT) Original-Received: from deyke2.fritz.box (p200300dbaf150b00d25099fffe0f9cc9.dip0.t-ipconnect.de. [2003:db:af15:b00:d250:99ff:fe0f:9cc9]) by smtp.gmail.com with ESMTPSA id v9-20020a170906858900b00773dbdd8205sm2480040ejx.168.2022.09.22.05.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Sep 2022 05:29:46 -0700 (PDT) Original-Received: from [127.0.0.1] (helo=deyke2.localdomain) by deyke2.fritz.box with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1obLKr-000855-2x; Thu, 22 Sep 2022 14:29:46 +0200 In-Reply-To: ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Thu, 22 Sep 2022 12:06:27 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::530; envelope-from=dieter.deyke@gmail.com; helo=mail-ed1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243411 Archived-At: Mattias Engdeg=C3=A5rd writes: > On Emacs master, starting Sokoban (from GNU ELPA) results in several warn= ings: > >> Warning (gamegrid): Using obsolete XEmacs style "glyph"; convert to an E= macs image-spec instead > > which apparently is from > >> (defvar sokoban-target-options >> `(((glyph >> [xpm :data ,sokoban-target-xpm]) > [...] > > where (after some digging) it seems that the vector needs to be > > ((:type xpm :data ,sokoban-target-xpm :ascent center))) > > somewhat non-intuitively, because of the slightly alarming line > >> (find-image data)) ;untested! > > in gamegrid.el. Suggested patch attached. > Is this all correct and as desired? Does it break anything when using old= Emacs versions? Thanks for your efforts, but that patch does not silence the warnings on my system. It looks like more is needed, but I do not know how to fix it. --=20 Dieter Deyke mailto:dieter.deyke@gmail.com Get my Gnupg key: gpg --keyserver keys.gnupg.net --recv-keys B116EA20