bug#1277: 23.0.60; vc revert dialog may need new lines

bug#1277: 23.0.60; vc revert dialog may need new lines

[robert marshall]

If you go into a vc-dir directory and mark a number of edited files
and then off the menu select 'Revert to base version', the dialog which
asks whether you want to discard changes lists all the files without
any new lines between the file names!

The yes/no buttons may then be an awful long way across the screen!

I've managed to cause emacs to hang with one revert request - maybe
because the dialog was just too wide?

Thanks


In GNU Emacs 23.0.60.8 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-10-28 on rajm-laptop
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: VC dir

Minor modes in effect:
  diff-auto-refine-mode: t
  recentf-mode: t
  show-paren-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

bug#1277: marked as done (23.0.60; vc revert dialog may need new lines)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]


Your message dated Thu, 30 Oct 2008 15:21:39 -0400
with message-id <8763n999do.fsf@cyd.mit.edu>
and subject line Re: 23.0.60; vc revert dialog may need new lines
has caused the Emacs bug report #1277,
regarding 23.0.60; vc revert dialog may need new lines
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1277: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1277
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3364 bytes --]

From: robert marshall <robert.marshall@tnei.co.uk>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; vc revert dialog may need new lines
Date: Thu, 30 Oct 2008 14:32:26 +0000
Message-ID: <871vxycfwl.fsf@tnei.co.uk>

If you go into a vc-dir directory and mark a number of edited files
and then off the menu select 'Revert to base version', the dialog which
asks whether you want to discard changes lists all the files without
any new lines between the file names!

The yes/no buttons may then be an awful long way across the screen!

I've managed to cause emacs to hang with one revert request - maybe
because the dialog was just too wide?

Thanks


In GNU Emacs 23.0.60.8 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-10-28 on rajm-laptop
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: VC dir

Minor modes in effect:
  diff-auto-refine-mode: t
  recentf-mode: t
  show-paren-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t




[-- Attachment #3: Type: message/rfc822, Size: 993 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: robert marshall <robert.marshall@tnei.co.uk>
Cc: 1277-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; vc revert dialog may need new lines
Date: Thu, 30 Oct 2008 15:21:39 -0400
Message-ID: <8763n999do.fsf@cyd.mit.edu>

I've checked in a fix, thanks.