unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Gemini Lasswell <gazally@runbox.com>
Cc: 24939@debbugs.gnu.org
Subject: bug#24939: [PATCH] Add tests for lisp/kmacro.el
Date: Wed, 30 Nov 2016 10:08:46 +0100	[thread overview]
Message-ID: <871sxtxrkx.fsf@gmx.de> (raw)
In-Reply-To: <m2mvgiqa2j.fsf@rainbow.local> (Gemini Lasswell's message of "Tue, 29 Nov 2016 12:56:36 -0800")

Gemini Lasswell <gazally@runbox.com> writes:

Hi,

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> > I don't like this implementation.
>>>
>>> This strategy is used in autorevert-tests.el and filenotify-tests.el,
>>> which is where I copied it from. So those should be changed too.
>>
>> Most probably.  But let's first see what better implementation we
>> could come up with.
>>
> Let me know what you think.

At first glance, looks OK to me. However, I didn't understand why the
existing implementation (watching messages in *Messages*) is bad.

Eli?

Best regards, Michael.





  reply	other threads:[~2016-11-30  9:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-13 21:23 bug#24939: [PATCH] Add tests for lisp/kmacro.el Gemini Lasswell
2016-11-14 15:49 ` Eli Zaretskii
2016-11-14 18:26   ` Gemini Lasswell
2016-11-14 18:47     ` Eli Zaretskii
2016-11-29 20:56       ` Gemini Lasswell
2016-11-30  9:08         ` Michael Albinus [this message]
2016-11-30 15:51           ` Eli Zaretskii
2016-11-30 16:51             ` Michael Albinus
2016-12-10 17:46             ` Gemini Lasswell
2016-12-31 17:42   ` Gemini Lasswell
2017-02-04 11:57     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871sxtxrkx.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=24939@debbugs.gnu.org \
    --cc=gazally@runbox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).