From: Eli Zaretskii <eliz@gnu.org>
To: Gemini Lasswell <gazally@runbox.com>
Cc: 24939@debbugs.gnu.org
Subject: bug#24939: [PATCH] Add tests for lisp/kmacro.el
Date: Mon, 14 Nov 2016 20:47:23 +0200 [thread overview]
Message-ID: <83vavphpac.fsf@gnu.org> (raw)
In-Reply-To: <m2polx6hp9.fsf@rainbow.local> (message from Gemini Lasswell on Mon, 14 Nov 2016 10:26:42 -0800)
> From: Gemini Lasswell <gazally@runbox.com>
> Cc:
> Date: Mon, 14 Nov 2016 10:26:42 -0800
>
> >> +(defmacro kmacro-tests-should-match-message (value &rest body)
> >> + "Verify that a message matching VALUE is issued while executing BODY.
> >> +Execute BODY, then check for a regexp match between
> >> +VALUE and any text written to *Messages* during the execution."
> >> + (declare (debug (stringp body))
> >> + (indent 1))
> >> + `(with-current-buffer (get-buffer-create "*Messages*")
> >> + (save-restriction
> >> + (narrow-to-region (point-max) (point-max))
> >> + ,@body
> >> + (should (string-match-p ,value (buffer-string))))))
> >
> > I don't like this implementation.
>
> This strategy is used in autorevert-tests.el and filenotify-tests.el,
> which is where I copied it from. So those should be changed too.
Most probably. But let's first see what better implementation we
could come up with.
> > get your hands on the messages more reliably. It is possible we
> > should have a more thorough infrastructure for collecting echo-area
> > messages, which probably means parts of it should be implemented in C,
> > but that's a separate project.
>
> That would definitely be helpful.
If you can provide a reasonable spec for such a feature, I'm sure
Someone™ will make it happen.
> >> + (kmacro-tests-should-match-message "No keyboard macro defined"
> >> + (apply #'funcall cmd))))
> > ^^^^^^^^^^^^^^^^^^^^^
> > Why not ert-simulate-command?
>
> I'll make that change. What do you think about changing
> ert-simulate-command to set current-prefix-arg? That would be very
> helpful.
Sounds like a useful extension to me.
> >> + ;; I'm attempting to make the test work even if keys have been
> >> + ;; rebound, but if this is failing try emacs -Q first.
> >
> > If this comment is still valid, then many other parts of the test have
> > the same problem, because they clearly assume the default key
> > bindings.
>
> That comment is out of date, since kmacro-tests-keymap should fix the
> problem. I'll remove it.
OK, then there are a couple more such comments in the patch.
Thanks.
next prev parent reply other threads:[~2016-11-14 18:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-13 21:23 bug#24939: [PATCH] Add tests for lisp/kmacro.el Gemini Lasswell
2016-11-14 15:49 ` Eli Zaretskii
2016-11-14 18:26 ` Gemini Lasswell
2016-11-14 18:47 ` Eli Zaretskii [this message]
2016-11-29 20:56 ` Gemini Lasswell
2016-11-30 9:08 ` Michael Albinus
2016-11-30 15:51 ` Eli Zaretskii
2016-11-30 16:51 ` Michael Albinus
2016-12-10 17:46 ` Gemini Lasswell
2016-12-31 17:42 ` Gemini Lasswell
2017-02-04 11:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vavphpac.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24939@debbugs.gnu.org \
--cc=gazally@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).