From: Noam Postavsky <npostavs@users.sourceforge.net>
To: David Glasser <glasser@davidglasser.net>
Cc: 28637@debbugs.gnu.org
Subject: bug#28637: [PATCH] Display commit in package description, if available
Date: Tue, 10 Oct 2017 21:16:36 -0400 [thread overview]
Message-ID: <871smacwln.fsf@users.sourceforge.net> (raw)
In-Reply-To: <CAN7QDoJc05xACCenHGn4zsmzBDknHZXBG8v9OwKXjy=NwYot-g@mail.gmail.com> (David Glasser's message of "Tue, 10 Oct 2017 15:46:53 -0700")
David Glasser <glasser@davidglasser.net> writes:
> Abbreviating the hash might be nice, but it seems like maybe that should be
> the job of the code that creates the metadata (ie in melpa's package builder)
> rather than the code that displays it.
Hmm, I'm not so sure about that, but looking at the result now I think
there's no need to abbreviate it anyway.
I think this should be okay to go to emacs-26; it's not strictly
speaking a bug fix, but it's obviously safe and this info is often
useful for package maintainers fielding bug reports, so it would be good
to have it more widely available. Eli?
> OK, a new version of the patch is below (is this the right way to send
> a new version of the patch? I am not used to mail-based git
> workflows):
Yup, that's fine. You can also use the -v option to git-format-patch in
order to make it more obvious that the patch is new. For small stuff
like this, it's not really important though.
I suppose you haven't assigned copyright for Emacs? No problem if not,
the patch is small enough to go in anyway, we just have to mark it.
next prev parent reply other threads:[~2017-10-11 1:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 23:06 bug#28637: [PATCH] Display commit in package description, if available David Glasser
2017-10-10 19:35 ` bug#28637: " David Glasser
2017-10-10 20:07 ` Eli Zaretskii
2017-10-10 22:05 ` David Glasser
2017-10-10 22:40 ` bug#28637: [PATCH] " Noam Postavsky
2017-10-10 22:46 ` David Glasser
2017-10-11 1:16 ` Noam Postavsky [this message]
2017-10-11 4:14 ` David Glasser
2017-10-11 10:41 ` Eli Zaretskii
2017-10-11 12:32 ` Noam Postavsky
2017-10-11 13:12 ` Eli Zaretskii
2017-10-23 23:58 ` Noam Postavsky
2017-10-24 14:46 ` Eli Zaretskii
2017-10-24 23:26 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871smacwln.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=28637@debbugs.gnu.org \
--cc=glasser@davidglasser.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).