From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28637: [PATCH] Display commit in package description, if available Date: Tue, 10 Oct 2017 21:16:36 -0400 Message-ID: <871smacwln.fsf@users.sourceforge.net> References: <874lr6d3tp.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507684634 12920 195.159.176.226 (11 Oct 2017 01:17:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 11 Oct 2017 01:17:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: 28637@debbugs.gnu.org To: David Glasser Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 11 03:17:04 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e25du-0001tN-Pq for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Oct 2017 03:17:02 +0200 Original-Received: from localhost ([::1]:38063 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e25e2-0005q1-2j for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Oct 2017 21:17:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e25dx-0005pw-D3 for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 21:17:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e25du-0000pa-HC for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 21:17:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52416) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e25du-0000p4-Cn for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 21:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e25dt-0008Cq-VP for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 21:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Oct 2017 01:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28637-submit@debbugs.gnu.org id=B28637.150768460731522 (code B ref 28637); Wed, 11 Oct 2017 01:17:01 +0000 Original-Received: (at 28637) by debbugs.gnu.org; 11 Oct 2017 01:16:47 +0000 Original-Received: from localhost ([127.0.0.1]:32864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e25df-0008CL-2O for submit@debbugs.gnu.org; Tue, 10 Oct 2017 21:16:47 -0400 Original-Received: from mail-io0-f178.google.com ([209.85.223.178]:55396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e25dd-0008C5-2O for 28637@debbugs.gnu.org; Tue, 10 Oct 2017 21:16:45 -0400 Original-Received: by mail-io0-f178.google.com with SMTP id z187so595106ioz.12 for <28637@debbugs.gnu.org>; Tue, 10 Oct 2017 18:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iFEhanQTAE031hM0J3P3EBe7DR6DIi9XJdNHVm67GXU=; b=pTwSzIorePso/kpYImHqKiFWksdUuUo7G6DImxTwdImMaZYLMQQ7NnSn8lCxoabEQm TSx3V3Zsesly0hekKcVN8/NBeJhXZZKhDftSZuQBOPz0Cue7f4bb2YytwOYGcV57FxRI af3KcOApuRdg44Yapsxy+cSXLNTZbJlzEf12u2F1e2V/l8rrT83JpNvVez1sVfh8tSP+ cgjDi3ugcX65KmLoh1iySLFzOfFxYPvonLJI8XEIj/1CABzwsaehWbDLOsNVdvGMBPwL XXR072udFM3uNiH+YBeWC1S1YebLiTk2kkT/zVONilI88hXhQW+f3BzV0o7IRZX0ma5Q rV9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=iFEhanQTAE031hM0J3P3EBe7DR6DIi9XJdNHVm67GXU=; b=W1+NsP0vFUHfal5rMJ1QP2099njY7qgmVeeDV0kkwf9eecPu0NcfodEabm3cZlSqIS ldduTPxmVGAKxYMfNaVeF1NZcINFaFv2mr/L0ucVbc3pN2gHCEHGr74ea8edKgFa3OFN 48co+b+cnoxDjJ/fckq0SfTH5z/W3ZU+JET6v8SEA+kgPCYpJYYyDbVGUOsVKnwOjazl XZc9LasTIVFpevr2797ywb2dhwWDLnS8SicdhbZwmdTsNBtTpVfheZvQUVX+9NvNs9Eu QOhMBpOR1YhyWb6P1jEejvBBRpLX24IWl9vlWXIhzEqXGQwHWUgeIAOM/mAaiNtvgnru OoXg== X-Gm-Message-State: AMCzsaXncKgLejs2NJU4OWeHpWnfoQxeRgoOGHs+lcZJkVywQ9gt2wLv qUzkW1IgxJvq4/Bpl5JOEh/SlQ== X-Google-Smtp-Source: AOwi7QAG8eZsbr1JAFxSlqpVH3GLEHwd8lnOvWnkKkjbHh6bvvej0SEBdugkqRHOgI2P/xmcg3vT7A== X-Received: by 10.107.56.68 with SMTP id f65mr14999796ioa.159.1507684599169; Tue, 10 Oct 2017 18:16:39 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i82sm1352263ioe.62.2017.10.10.18.16.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Oct 2017 18:16:38 -0700 (PDT) In-Reply-To: (David Glasser's message of "Tue, 10 Oct 2017 15:46:53 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138203 Archived-At: David Glasser writes: > Abbreviating the hash might be nice, but it seems like maybe that should be > the job of the code that creates the metadata (ie in melpa's package builder) > rather than the code that displays it. Hmm, I'm not so sure about that, but looking at the result now I think there's no need to abbreviate it anyway. I think this should be okay to go to emacs-26; it's not strictly speaking a bug fix, but it's obviously safe and this info is often useful for package maintainers fielding bug reports, so it would be good to have it more widely available. Eli? > OK, a new version of the patch is below (is this the right way to send > a new version of the patch? I am not used to mail-based git > workflows): Yup, that's fine. You can also use the -v option to git-format-patch in order to make it more obvious that the patch is new. For small stuff like this, it's not really important though. I suppose you haven't assigned copyright for Emacs? No problem if not, the patch is small enough to go in anyway, we just have to mark it.