* bug#29865: 26.0.50; data-test-popcnt fails in 32bit
@ 2017-12-27 15:42 Stefan Monnier
2019-07-14 18:02 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2017-12-27 15:42 UTC (permalink / raw)
To: 29865; +Cc: Mark Oteiza
Package: Emacs
Version: 26.0.50
"make check" keeps failing for me in test/src/data-tests.el on
data-tests-logcount, because the integer constants used in
data-tests-popcnt are too large for my 32bit build and hence are turned
into floats.
The backtrace it gives me is below.
The 1431655765.0 constant is the result of reading #x55555555!
Stefan
Test data-tests-logcount backtrace:
logand(127 1431655765.0)
(- byte (logand (lsh byte -1) 1431655765.0))
(setq byte (- byte (logand (lsh byte -1) 1431655765.0)))
data-tests-popcnt(-255)
(= (logcount n) (data-tests-popcnt n))
(setq --cl-flag-- (= (logcount n) (data-tests-popcnt n)))
(progn (setq n (car --cl-var--)) (setq --cl-flag-- (= (logcount n) (
(and (consp --cl-var--) (progn (setq n (car --cl-var--)) (setq --cl-
(while (and (consp --cl-var--) (progn (setq n (car --cl-var--)) (set
(let* ((--cl-var-- (number-sequence -255 255)) (n nil) (--cl-flag--
(setq value-347 (let* ((--cl-var-- (number-sequence -255 255)) (n ni
(unwind-protect (setq value-347 (let* ((--cl-var-- (number-sequence
(if (unwind-protect (setq value-347 (let* ((--cl-var-- (number-seque
(let (form-description-348) (if (unwind-protect (setq value-347 (let
(let ((value-347 (gensym "ert-form-evaluation-aborted-"))) (let (for
(lambda nil (let ((value-347 (gensym "ert-form-evaluation-aborted-")
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name data-tests-logcount :documentation ni
ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit(nil)
eval((ert-run-tests-batch-and-exit nil))
command-line-1(("-L" ":." "-l" "ert" "-l" "src/data-tests.el" "--eva
command-line()
normal-top-level()
Test data-tests-logcount condition:
(wrong-type-argument integer-or-marker-p 1431655765.0)
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#29865: 26.0.50; data-test-popcnt fails in 32bit
2017-12-27 15:42 bug#29865: 26.0.50; data-test-popcnt fails in 32bit Stefan Monnier
@ 2019-07-14 18:02 ` Lars Ingebrigtsen
2019-07-15 13:02 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-14 18:02 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Mark Oteiza, 29865
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
> "make check" keeps failing for me in test/src/data-tests.el on
> data-tests-logcount, because the integer constants used in
> data-tests-popcnt are too large for my 32bit build and hence are turned
> into floats.
>
> The backtrace it gives me is below.
> The 1431655765.0 constant is the result of reading #x55555555!
Is this still relevant now that Emacs has bignum support?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#29865: 26.0.50; data-test-popcnt fails in 32bit
2019-07-14 18:02 ` Lars Ingebrigtsen
@ 2019-07-15 13:02 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2019-07-15 13:02 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Mark Oteiza, 29865-done
> Is this still relevant now that Emacs has bignum support?
No, indeed: I don't see this test error any more, so it's likely been
fixed by the introduction of bignums.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-15 13:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-27 15:42 bug#29865: 26.0.50; data-test-popcnt fails in 32bit Stefan Monnier
2019-07-14 18:02 ` Lars Ingebrigtsen
2019-07-15 13:02 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).