unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rgm@gnu.org, 15803@debbugs.gnu.org
Subject: bug#15803: default-file-name-coding-system: utf-8 better than latin-1 these days?
Date: Fri, 11 Sep 2020 16:18:32 +0200	[thread overview]
Message-ID: <871rj8xupz.fsf@gnus.org> (raw)
In-Reply-To: <837dt0h4er.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Sep 2020 15:41:16 +0300")

I'm just poking around to see what's different between the way the files
are compiled in the test directory and the lisp directory, because they
should either both fail or not.

So here's how "make" i test does it:

EMACSLOADPATH= LC_ALL=C EMACS_TEST_DIRECTORY=/home/larsi/src/emacs/f�o/test  "../src/emacs" --module-assertions --no-init-file --no-site-file --no-site-lisp -L ":."  --batch -f batch-byte-compile lisp/eshell/eshell-tests.el

Here's how "make" in Lisp does it:

EMACSLOADPATH= '../src/emacs' -batch --no-site-file --no-site-lisp --eval '(setq load-prefer-newer t)'  -f batch-byte-compile emacs-lisp/bytecomp.el

And, indeed, if I remove "LC_ALL=C" from the line, then this compiles
successfully.

*phew*

Hm...  in fact, everything compiles successfully without LC_ALL?

However, when the tests run (in the latin-1 environment) 11 tests fail:

SUMMARY OF TEST RESULTS
-----------------------
Files examined: 305
Ran 4200 tests, 4097 results as expected, 29 unexpected, 74 skipped
1 files did not contain any tests:
  src/emacs-module-tests.log
11 files contained unexpected results:
  src/regex-emacs-tests.log
  lisp/vc/vc-bzr-tests.log
  lisp/vc/diff-mode-tests.log
  lisp/time-stamp-tests.log
  lisp/net/shr-tests.log
  lisp/gnus/mml-sec-tests.log
  lisp/epg-tests.log
  lisp/emacs-lisp/package-tests.log
  lisp/emacs-lisp/faceup-tests/faceup-test-files.log
  lisp/cedet/semantic-utest-ia.log
  lib-src/emacsclient-tests.log

As a comparison, removing the LC_ALL in an utf-8 environment (with a
pure-ascii path) gives me:

SUMMARY OF TEST RESULTS
-----------------------
Files examined: 305
Ran 4231 tests, 4150 results as expected, 6 unexpected, 75 skipped
6 files contained unexpected results:
  src/emacs-module-tests.log
  src/callint-tests.log
  lisp/vc/vc-bzr-tests.log
  lisp/subr-tests.log
  lisp/files-tests.log
  lisp/emacs-lisp/gv-tests.log

The bzr test fails because of the brz/bzr thing, but the LC_ALL is
apparently needed for the other five things.

So: In conclusion, I this Glenn's patch needs more work before
applying.  :-)  But at least we now knows that it breaks, and why (well,
for some of it).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no






  reply	other threads:[~2020-09-11 14:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-04 18:45 bug#15803: default-file-name-coding-system: utf-8 better than latin-1 these days? Glenn Morris
2017-12-01  1:52 ` Glenn Morris
2017-12-01  7:54   ` Eli Zaretskii
2017-12-05  0:35     ` Glenn Morris
2017-12-08  9:46       ` Eli Zaretskii
2017-12-12  1:38         ` Glenn Morris
2020-09-09 13:15           ` Lars Ingebrigtsen
2020-09-09 15:00             ` Eli Zaretskii
2020-09-10 13:07               ` Lars Ingebrigtsen
2020-09-10 14:39                 ` Eli Zaretskii
2020-09-11 10:55                   ` Lars Ingebrigtsen
2020-09-11 11:05                     ` Eli Zaretskii
2020-09-11 11:27                       ` Lars Ingebrigtsen
2020-09-11 12:24                         ` Eli Zaretskii
2020-09-11 12:33                           ` Lars Ingebrigtsen
2020-09-11 12:41                             ` Eli Zaretskii
2020-09-11 14:18                               ` Lars Ingebrigtsen [this message]
2020-09-11 14:27                                 ` Lars Ingebrigtsen
2020-09-11 14:46                                   ` Eli Zaretskii
2020-09-11 14:54                                     ` Lars Ingebrigtsen
2020-09-11 15:11                                       ` Eli Zaretskii
2020-09-12  8:47                                         ` Michael Albinus
2020-09-12 11:21                                         ` Lars Ingebrigtsen
2020-09-11 12:39                           ` Lars Ingebrigtsen
2020-09-11 12:45                             ` Eli Zaretskii
2020-09-09 13:33       ` Stefan Kangas
2020-09-09 15:09         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rj8xupz.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=15803@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).