unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Richard Sharman <rsharman@pobox.com>
Cc: 45952@debbugs.gnu.org, 45950@debbugs.gnu.org
Subject: bug#45950: 27.1; Certain regexps can cause comint-redirect-results-list-from-process to loop.
Date: Tue, 19 Jan 2021 05:16:02 +0100	[thread overview]
Message-ID: <871rehr27x.fsf_-_@gnus.org> (raw)
In-Reply-To: <B14DD786-D1A5-4078-A747-B891AD6E34C5@pobox.com> (Richard Sharman's message of "Sun, 17 Jan 2021 21:48:16 -0800")

Richard Sharman <rsharman@pobox.com> writes:

> Sorry, there was a mistake on the patch on my previous message; 
> the (re-search-forward regexp nil t)) was inadvertently changed to
> (re-search-forward regexp nil).
>
> Sorry.
>
> Here’s the corrected version:

[...]

> + (if (equal (point) last-point)
> +    (forward-line 1)
> +  (push (buffer-substring-no-properties
> + (match-beginning regexp-group)
> + (match-end regexp-group))
> + results))
> + (setq last-point (point)))
>        (nreverse results))))

I can reproduce the infloop in Emacs 28, but I don't think this is quite
the correct fix -- if you've asked for "^.*$", then you should get an
empty string in the result set, and not just "a" "b" "d".  So I've
installed a variant of what you suggest in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  parent reply	other threads:[~2021-01-19  4:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18  1:24 bug#45950: 27.1; Certain regexps can cause comint-redirect-results-list-from-process to loop Richard Sharman
2021-01-18  5:48 ` bug#45952: Correction to: " Richard Sharman
2021-01-18 17:17   ` bug#45952: was really a correction to 45950 Richard Sharman
2021-01-19  4:16   ` Lars Ingebrigtsen [this message]
2021-01-18 17:17 ` bug#45950: Please see 45952 for correction to patch Richard Sharman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rehr27x.fsf_-_@gnus.org \
    --to=larsi@gnus.org \
    --cc=45950@debbugs.gnu.org \
    --cc=45952@debbugs.gnu.org \
    --cc=rsharman@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).