From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45950: 27.1; Certain regexps can cause comint-redirect-results-list-from-process to loop. Date: Tue, 19 Jan 2021 05:16:02 +0100 Message-ID: <871rehr27x.fsf_-_@gnus.org> References: <1BD39C98-94C1-4814-A25B-A236AAF84027@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1440"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45952@debbugs.gnu.org, 45950@debbugs.gnu.org To: Richard Sharman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 19 05:17:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1iSC-0000Cs-HY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 05:17:16 +0100 Original-Received: from localhost ([::1]:53438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1iSB-0005uV-0w for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Jan 2021 23:17:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1iRy-0005uC-53 for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2021 23:17:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37468) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1iRx-0006Ng-SR for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2021 23:17:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l1iRx-0006lr-Mp for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2021 23:17:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jan 2021 04:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45950 X-GNU-PR-Package: emacs Original-Received: via spool by 45950-submit@debbugs.gnu.org id=B45950.161102978225951 (code B ref 45950); Tue, 19 Jan 2021 04:17:01 +0000 Original-Received: (at 45950) by debbugs.gnu.org; 19 Jan 2021 04:16:22 +0000 Original-Received: from localhost ([127.0.0.1]:49009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1iRJ-0006kT-Ix for submit@debbugs.gnu.org; Mon, 18 Jan 2021 23:16:21 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:53982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1iRH-0006kB-Dw; Mon, 18 Jan 2021 23:16:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mQLnYBwXkPPvp4vmwpnTLbG+ujDYlOUajFiYN82a4RI=; b=D/pJOgS7hkbtqRTZPaA40N7+lR lZAW0PzC2HWPDuUeLcqQ5rKCVEJV8RSFyuCAI0fITCQHaGvloqitAb4UmGGFsprvhgfzVJLccqrQI cLdxQwEtD8L6Ni3RP3R2RvfTRbDmIfO24F3Jmji/1AcNVnRnJ4p0ECYPohXOS6NmZIzM=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1iR1-0003Cc-SL; Tue, 19 Jan 2021 05:16:12 +0100 X-Now-Playing: The Durutti Column's _Without Mercy (4)_: "Blind Elevator Girl" In-Reply-To: (Richard Sharman's message of "Sun, 17 Jan 2021 21:48:16 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198119 Archived-At: Richard Sharman writes: > Sorry, there was a mistake on the patch on my previous message;=20 > the (re-search-forward regexp nil t)) was inadvertently changed to > (re-search-forward regexp nil). > > Sorry. > > Here=E2=80=99s the corrected version: [...] > + (if (equal (point) last-point) > + (forward-line 1) > + (push (buffer-substring-no-properties > + (match-beginning regexp-group) > + (match-end regexp-group)) > + results)) > + (setq last-point (point))) > (nreverse results)))) I can reproduce the infloop in Emacs 28, but I don't think this is quite the correct fix -- if you've asked for "^.*$", then you should get an empty string in the result set, and not just "a" "b" "d". So I've installed a variant of what you suggest in Emacs 28. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no