* bug#46401: Typo in commit 0cc35e1431
@ 2021-02-09 12:59 Dario Gjorgjevski
2021-02-09 13:28 ` Basil L. Contovounesios
0 siblings, 1 reply; 2+ messages in thread
From: Dario Gjorgjevski @ 2021-02-09 12:59 UTC (permalink / raw)
To: 46401
Hi,
There is a typo in commit 0cc35e1431:
$ git show --oneline 0cc35e1431 lisp/progmodes/elisp-mode.el
0cc35e1431 Move all usages of `values' to `values--store-value'
diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
index 9a36206bfd..0325d4ea75 100644
--- a/lisp/progmodes/elisp-mode.el
+++ b/lisp/progmodes/elisp-mode.el
@@ -1268,9 +1268,8 @@ If `eval-expression-debug-on-error' is non-nil, which is the default,
this command arranges for all errors to enter the debugger."
(interactive "P")
(if (null eval-expression-debug-on-error)
- (let ((value (elisp--eval-last-sexp eval-last-sexp-arg-internal)))
- (push value values)
- value)
+ (values--store-values
+ (elisp--eval-last-sexp eval-last-sexp-arg-internal))
(let ((value
(let ((debug-on-error elisp--eval-last-sexp-fake-value))
(cons (elisp--eval-last-sexp eval-last-sexp-arg-internal)
Instead of values--store-values, it should say values--store-value.
Best regards,
Dario
--
$ keyserver=hkps://hkps.pool.sks-keyservers.net
$ keyid=744A4F0B4F1C9371
$ gpg --keyserver $keyserver --search-keys $keyid
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#46401: Typo in commit 0cc35e1431
2021-02-09 12:59 bug#46401: Typo in commit 0cc35e1431 Dario Gjorgjevski
@ 2021-02-09 13:28 ` Basil L. Contovounesios
0 siblings, 0 replies; 2+ messages in thread
From: Basil L. Contovounesios @ 2021-02-09 13:28 UTC (permalink / raw)
To: Dario Gjorgjevski; +Cc: 46401-done
tags 46401 fixed
close 46401 28.1
quit
Dario Gjorgjevski <dario.gjorgjevski@gmail.com> writes:
> There is a typo in commit 0cc35e1431:
[...]
> Instead of values--store-values, it should say values--store-value.
Thanks, this has already been fixed.
; Fix recent change in eval-last-sexp
8e3ace4297 2021-02-09 13:01:18 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8e3ace4297512d9f1a2825d332b7e70c6ae3ea15
--
Basil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-09 13:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09 12:59 bug#46401: Typo in commit 0cc35e1431 Dario Gjorgjevski
2021-02-09 13:28 ` Basil L. Contovounesios
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).