From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: nicolas petton <nicolas@petton.fr>, 46754-done@debbugs.gnu.org
Subject: bug#46754: 28.0.50; Various map.el fixes and improvements
Date: Sat, 06 Mar 2021 17:52:16 +0000 [thread overview]
Message-ID: <871rcsqien.fsf@tcd.ie> (raw)
In-Reply-To: <jwvy2f6odgt.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 01 Mar 2021 14:59:27 -0500")
tags 46754 fixed
close 46754 28.1
quit
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> WDYT?
>
> Looks fine to me. I wouldn't advertise the default `map-insert`
> implementation too much (especially not saying "it works for arrays and
> hash-tables"), since its performance makes it undesirable (and it is
> not specific to hash-tables nor arrays).
>
>> -In the base definition, MAP can be an alist, hash-table, or array."
>> +In the base definition, MAP can be a list, hash-table, or array."
>
> A list isn't a map, so I think it would be better to write "alist/plist" or
> somesuch to avoid giving the impression that lists can be treated as
> maps in general.
Thanks, both points make sense, and I think I addressed them, so I'm
closing this report.
Various map.el improvements
d925121b1e 2021-03-06 16:00:52 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d925121b1e1cdf953705a5da43f8092f2a6e1d8c
--
Basil
prev parent reply other threads:[~2021-03-06 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 15:15 bug#46754: 28.0.50; Various map.el fixes and improvements Basil L. Contovounesios
2021-03-01 19:59 ` Stefan Monnier
2021-03-06 17:52 ` Basil L. Contovounesios [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rcsqien.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=46754-done@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=nicolas@petton.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).