From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#46754: 28.0.50; Various map.el fixes and improvements Date: Sat, 06 Mar 2021 17:52:16 +0000 Message-ID: <871rcsqien.fsf@tcd.ie> References: <87zgztcxac.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17076"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: nicolas petton , 46754-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 06 18:53:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIb71-0004KP-Di for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 18:53:11 +0100 Original-Received: from localhost ([::1]:33598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIb70-0004V6-1u for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 12:53:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIb6t-0004Us-96 for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 12:53:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54939) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIb6t-0007Km-25 for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 12:53:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lIb6s-0001cu-V3 for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 12:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Mar 2021 17:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46754 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 46754-done@debbugs.gnu.org id=D46754.16150531466196 (code D ref 46754); Sat, 06 Mar 2021 17:53:02 +0000 Original-Received: (at 46754-done) by debbugs.gnu.org; 6 Mar 2021 17:52:26 +0000 Original-Received: from localhost ([127.0.0.1]:38249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIb6H-0001bn-TU for submit@debbugs.gnu.org; Sat, 06 Mar 2021 12:52:26 -0500 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:37311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIb6G-0001bS-5Q for 46754-done@debbugs.gnu.org; Sat, 06 Mar 2021 12:52:24 -0500 Original-Received: by mail-wr1-f46.google.com with SMTP id v15so6292083wrx.4 for <46754-done@debbugs.gnu.org>; Sat, 06 Mar 2021 09:52:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=B2vWn889tljvnXNWcgmIEa1jusd/goieRzG/qLjvNCg=; b=FdbORiL37Rw7ViCe+cnKIpeZSSrMbVXOyBQkgV3E6IvSi6vjhHK7NOv9+dJxGQ3eKZ S3TIYlgbR5hvIBWtUh9Zf7+Hx6BwyTTjOnkWGPEDFVe5dyu7iSxBjitAq3g7yrbOrAuy BgyJTER8utJnnLAPOuwc+pxHpkCrRGCbxyUxNu+lDbwEUla6NcPsetICz6CO83c33Wq0 JPeEqHPXFPDkHcp7Oe8/XNRbZ0X+NQxwzAQt6PsyND5nvF+WvNy9LO5msyn1sg0Y4i8Z /XZh9gkrpBoGxI/G0kQx8hZ0VNBisRmMEbi5H6yi8xVFRA0G18eyy0m72i832KTLS9Hk Ub0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=B2vWn889tljvnXNWcgmIEa1jusd/goieRzG/qLjvNCg=; b=g5C6X+H2Uqn/RuXa2JqRlj1sQ/qLIr3U9ER/+3WrF4m3h/5t4xv1wmf1/gIscs96xx pQUOjdIurJ5+IaG2gWgAkbPffsloEZEoO1WI1bdEU8nwtMZnXtsSBpD0EuNITvmBFL7k /ovWBRzhn6zV6Lg+WHihYmXt+31EhZQ3JeHYFvfWSqoDo59RWmBMcACyEt2Tkp+6gFv0 rsjk6wiQrTqIgO8ALe23OSWNgzC2kMFOSyVkwM8OTqPmGBxq0UYQ4n4/+ryY8FZgOoaS GTpdnhvpCRMXvI/TBy8EW/KuG3kJByHws6xxTCjj4nNJfeds6lthPZSnoLh4tTF2i5TC rHpw== X-Gm-Message-State: AOAM5338h8jFGIcucvjH71audgBmZGf67lrx7/sEW+8aP+wcHx+9U5pq 7lE6gmV5O5WXRyDQIf8GuIeEVw== X-Google-Smtp-Source: ABdhPJz8AutooYbaWUoEWgajTRrn9V7aPa9pyX3q7hYlM2AmzPM9gYNN6FWn/W166jYzM4OHLTUk1Q== X-Received: by 2002:adf:dc91:: with SMTP id r17mr14988707wrj.293.1615053138303; Sat, 06 Mar 2021 09:52:18 -0800 (PST) Original-Received: from localhost ([51.37.57.126]) by smtp.gmail.com with ESMTPSA id a14sm10447026wrg.84.2021.03.06.09.52.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 09:52:17 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Mon, 01 Mar 2021 14:59:27 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201651 Archived-At: tags 46754 fixed close 46754 28.1 quit Stefan Monnier writes: >> WDYT? > > Looks fine to me. I wouldn't advertise the default `map-insert` > implementation too much (especially not saying "it works for arrays and > hash-tables"), since its performance makes it undesirable (and it is > not specific to hash-tables nor arrays). > >> -In the base definition, MAP can be an alist, hash-table, or array." >> +In the base definition, MAP can be a list, hash-table, or array." > > A list isn't a map, so I think it would be better to write "alist/plist" or > somesuch to avoid giving the impression that lists can be treated as > maps in general. Thanks, both points make sense, and I think I addressed them, so I'm closing this report. Various map.el improvements d925121b1e 2021-03-06 16:00:52 +0000 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d925121b1e1cdf953705a5da43f8092f2a6e1d8c -- Basil