* bug#47004: 28.0.50; [PATCH] Use `pop-to-buffer-same-window' in `project-eshell'
@ 2021-03-08 11:50 Simen Heggestøyl
2021-03-08 11:55 ` Dmitry Gutov
0 siblings, 1 reply; 3+ messages in thread
From: Simen Heggestøyl @ 2021-03-08 11:50 UTC (permalink / raw)
To: 47004; +Cc: Dmitry Gutov
[-- Attachment #1: Type: text/plain, Size: 140 bytes --]
Hi.
Could `project-eshell' be changed to use `pop-to-buffer-same-window'
instead of `pop-to-buffer' to match the behavior of `M-x eshell'?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Use-pop-to-buffer-same-window-in-project-eshell.patch --]
[-- Type: text/x-diff, Size: 959 bytes --]
From a7109bbf417a322a7066fcdc93e43ca457b236ff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= <simenheg@gmail.com>
Date: Mon, 8 Mar 2021 12:38:41 +0100
Subject: [PATCH] Use `pop-to-buffer-same-window' in `project-eshell'
* lisp/progmodes/project.el (project-eshell): Use
`pop-to-buffer-same-window' instead of `pop-to-buffer' to match the
behavior of `M-x eshell'.
---
lisp/progmodes/project.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index abe563bec0..d59da2496a 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -924,7 +924,7 @@ project-eshell
"-eshell*"))
(eshell-buffer (get-buffer eshell-buffer-name)))
(if (and eshell-buffer (not current-prefix-arg))
- (pop-to-buffer eshell-buffer)
+ (pop-to-buffer-same-window eshell-buffer)
(eshell t))))
;;;###autoload
--
2.30.1
[-- Attachment #3: Type: text/plain, Size: 9 bytes --]
-- Simen
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#47004: 28.0.50; [PATCH] Use `pop-to-buffer-same-window' in `project-eshell'
2021-03-08 11:50 bug#47004: 28.0.50; [PATCH] Use `pop-to-buffer-same-window' in `project-eshell' Simen Heggestøyl
@ 2021-03-08 11:55 ` Dmitry Gutov
2021-03-08 11:59 ` Simen Heggestøyl
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Gutov @ 2021-03-08 11:55 UTC (permalink / raw)
To: Simen Heggestøyl, 47004
On 08.03.2021 13:50, Simen Heggestøyl wrote:
> Could `project-eshell' be changed to use `pop-to-buffer-same-window'
> instead of `pop-to-buffer' to match the behavior of `M-x eshell'?
Sure, please go ahead.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#47004: 28.0.50; [PATCH] Use `pop-to-buffer-same-window' in `project-eshell'
2021-03-08 11:55 ` Dmitry Gutov
@ 2021-03-08 11:59 ` Simen Heggestøyl
0 siblings, 0 replies; 3+ messages in thread
From: Simen Heggestøyl @ 2021-03-08 11:59 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 47004-done
That was quick.
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 08.03.2021 13:50, Simen Heggestøyl wrote:
>> Could `project-eshell' be changed to use `pop-to-buffer-same-window'
>> instead of `pop-to-buffer' to match the behavior of `M-x eshell'?
>
> Sure, please go ahead.
Went ahead.
Thanks!
-- Simen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-08 11:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 11:50 bug#47004: 28.0.50; [PATCH] Use `pop-to-buffer-same-window' in `project-eshell' Simen Heggestøyl
2021-03-08 11:55 ` Dmitry Gutov
2021-03-08 11:59 ` Simen Heggestøyl
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).