* bug#39558: 26.3; icomplete and display *Completions* in child frame
@ 2020-02-11 6:55 Andrii Kolomoiets
2020-02-11 15:35 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Andrii Kolomoiets @ 2020-02-11 6:55 UTC (permalink / raw)
To: 39558
1. emacs -Q
2. evaluate
(customize-set-variable
'display-buffer-alist
'(("\\*Completions\\*" display-buffer-in-child-frame)))
3. M-x icomplete-mode
4. M-x f<TAB>
Error in post-command-hook (icomplete-post-command-hook): (wrong-type-argument number-or-marker-p nil)
In GNU Emacs 26.3 (build 1, x86_64-apple-darwin18.2.0, NS appkit-1671.20 Version 10.14.3 (Build 18D109))
of 2019-09-02 built on builder10-14.porkrind.org
Windowing system distributor 'Apple', version 10.3.1894
Recent messages:
(("\\*Completions\\*" display-buffer-in-child-frame))
Icomplete mode enabled
Making completion list...
In #<buffer *Minibuf-1*> (w=#<window 5 on *Completions*>): nil
Error in post-command-hook (icomplete-post-command-hook): (wrong-type-argument number-or-marker-p nil)
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#39558: 26.3; icomplete and display *Completions* in child frame
2020-02-11 6:55 bug#39558: 26.3; icomplete and display *Completions* in child frame Andrii Kolomoiets
@ 2020-02-11 15:35 ` Eli Zaretskii
2020-02-12 9:15 ` Andrii Kolomoiets
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2020-02-11 15:35 UTC (permalink / raw)
To: Andrii Kolomoiets; +Cc: 39558
> From: Andrii Kolomoiets <andreyk.mad@gmail.com>
> Date: Tue, 11 Feb 2020 08:55:48 +0200
>
> 1. emacs -Q
> 2. evaluate
> (customize-set-variable
> 'display-buffer-alist
> '(("\\*Completions\\*" display-buffer-in-child-frame)))
> 3. M-x icomplete-mode
> 4. M-x f<TAB>
>
> Error in post-command-hook (icomplete-post-command-hook): (wrong-type-argument number-or-marker-p nil)
I cannot reproduce this, so maybe this is Darwin-specific.
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#39558: 26.3; icomplete and display *Completions* in child frame
2020-02-11 15:35 ` Eli Zaretskii
@ 2020-02-12 9:15 ` Andrii Kolomoiets
2021-08-11 12:34 ` Lars Ingebrigtsen
0 siblings, 1 reply; 7+ messages in thread
From: Andrii Kolomoiets @ 2020-02-12 9:15 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 39558
Eli Zaretskii <eliz@gnu.org> writes:
>> 1. emacs -Q
>> 2. evaluate
>> (customize-set-variable
>> 'display-buffer-alist
>> '(("\\*Completions\\*" display-buffer-in-child-frame)))
>> 3. M-x icomplete-mode
>> 4. M-x f<TAB>
>>
>> Error in post-command-hook (icomplete-post-command-hook): (wrong-type-argument number-or-marker-p nil)
>
> I cannot reproduce this, so maybe this is Darwin-specific.
You are right.
There are this code in lisp/term/ns-win.el:581:
(add-hook 'after-make-frame-functions 'select-frame)
Evaluating it allow you to catch that error in
icomplete-post-command-hook under X as well.
To avoid original issue under Darwin:
(setq after-make-frame-functions nil)
(customize-set-variable
'display-buffer-alist
'(("\\*Completions\\*" display-buffer-in-child-frame
(child-frame-parameters . ((minibuffer . nil))))))
(The `(minibuffer . nil)' frame parameter is required if we want to leave
focus on original frame. IDK why `(no-focus-on-map . t)' doesn't help
here.)
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#39558: 26.3; icomplete and display *Completions* in child frame
2020-02-12 9:15 ` Andrii Kolomoiets
@ 2021-08-11 12:34 ` Lars Ingebrigtsen
2021-08-11 21:16 ` Alan Third
2021-08-12 20:11 ` Andrii Kolomoiets
0 siblings, 2 replies; 7+ messages in thread
From: Lars Ingebrigtsen @ 2021-08-11 12:34 UTC (permalink / raw)
To: Andrii Kolomoiets; +Cc: 39558, Alan Third
Andrii Kolomoiets <andreyk.mad@gmail.com> writes:
>> I cannot reproduce this, so maybe this is Darwin-specific.
>
> You are right.
>
> There are this code in lisp/term/ns-win.el:581:
> (add-hook 'after-make-frame-functions 'select-frame)
>
> Evaluating it allow you to catch that error in
> icomplete-post-command-hook under X as well.
>
> To avoid original issue under Darwin:
>
> (setq after-make-frame-functions nil)
> (customize-set-variable
> 'display-buffer-alist
> '(("\\*Completions\\*" display-buffer-in-child-frame
> (child-frame-parameters . ((minibuffer . nil))))))
>
> (The `(minibuffer . nil)' frame parameter is required if we want to leave
> focus on original frame. IDK why `(no-focus-on-map . t)' doesn't help
> here.)
Andrii, are you still seeing this issue in more recent versions of
Emacs? If so, perhaps Alan has some comments here (added to the CCs).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#39558: 26.3; icomplete and display *Completions* in child frame
2021-08-11 12:34 ` Lars Ingebrigtsen
@ 2021-08-11 21:16 ` Alan Third
2021-08-12 20:11 ` Andrii Kolomoiets
1 sibling, 0 replies; 7+ messages in thread
From: Alan Third @ 2021-08-11 21:16 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 39558, Andrii Kolomoiets
On Wed, Aug 11, 2021 at 02:34:37PM +0200, Lars Ingebrigtsen wrote:
> Andrii Kolomoiets <andreyk.mad@gmail.com> writes:
>
> >> I cannot reproduce this, so maybe this is Darwin-specific.
> >
> > You are right.
> >
> > There are this code in lisp/term/ns-win.el:581:
> > (add-hook 'after-make-frame-functions 'select-frame)
> >
> > Evaluating it allow you to catch that error in
> > icomplete-post-command-hook under X as well.
> >
> > To avoid original issue under Darwin:
> >
> > (setq after-make-frame-functions nil)
> > (customize-set-variable
> > 'display-buffer-alist
> > '(("\\*Completions\\*" display-buffer-in-child-frame
> > (child-frame-parameters . ((minibuffer . nil))))))
> >
> > (The `(minibuffer . nil)' frame parameter is required if we want to leave
> > focus on original frame. IDK why `(no-focus-on-map . t)' doesn't help
> > here.)
>
> Andrii, are you still seeing this issue in more recent versions of
> Emacs? If so, perhaps Alan has some comments here (added to the CCs).
I don't know if it's any help but the after-make-frame-functions
setting is related to bug#3397.
I've had a look and haven't been able to work out what we need to do
to fix that one.
--
Alan Third
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#39558: 26.3; icomplete and display *Completions* in child frame
2021-08-11 12:34 ` Lars Ingebrigtsen
2021-08-11 21:16 ` Alan Third
@ 2021-08-12 20:11 ` Andrii Kolomoiets
1 sibling, 0 replies; 7+ messages in thread
From: Andrii Kolomoiets @ 2021-08-12 20:11 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 39558, Alan Third
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Andrii Kolomoiets <andreyk.mad@gmail.com> writes:
>
>>> I cannot reproduce this, so maybe this is Darwin-specific.
>>
>> You are right.
>>
>> There are this code in lisp/term/ns-win.el:581:
>> (add-hook 'after-make-frame-functions 'select-frame)
>>
>> Evaluating it allow you to catch that error in
>> icomplete-post-command-hook under X as well.
>
> Andrii, are you still seeing this issue in more recent versions of
> Emacs? If so, perhaps Alan has some comments here (added to the CCs).
Yes. I can reproduce this in recent Emacs version.
--
Andrii
^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <<m2tv3x1ukr.fsf@10-1-1-147.office.area>]
end of thread, other threads:[~2021-08-12 20:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 6:55 bug#39558: 26.3; icomplete and display *Completions* in child frame Andrii Kolomoiets
2020-02-11 15:35 ` Eli Zaretskii
2020-02-12 9:15 ` Andrii Kolomoiets
2021-08-11 12:34 ` Lars Ingebrigtsen
2021-08-11 21:16 ` Alan Third
2021-08-12 20:11 ` Andrii Kolomoiets
[not found] <<m2tv3x1ukr.fsf@10-1-1-147.office.area>
[not found] ` <<83a75prvau.fsf@gnu.org>
2020-02-11 18:22 ` Drew Adams
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).