* bug#50976: 28.0.50; Tramp read-file-name regression
@ 2021-10-02 19:19 Juri Linkov
2021-10-05 14:32 ` Michael Albinus
0 siblings, 1 reply; 5+ messages in thread
From: Juri Linkov @ 2021-10-02 19:19 UTC (permalink / raw)
To: 50976
This is a recent regression. When visiting a remote Dired buffer,
marking one file with C-SPC (set-mark-command), then moving point
to another Dired file, then typing '=' (dired-diff) and 'RET'
fails with the error "Attempt to compare the file to itself".
This is because 'read-file-name' in the interactive spec of 'dired-diff'
now returns the remote directory name after typing RET,
while some time ago it correctly returned the default file name,
that is the marked file that was used as the arg 'file' of 'dired-diff'.
In local filesystems, RET still correctly returns the default file,
not a directory name as it does now for remote directories.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#50976: 28.0.50; Tramp read-file-name regression
2021-10-02 19:19 bug#50976: 28.0.50; Tramp read-file-name regression Juri Linkov
@ 2021-10-05 14:32 ` Michael Albinus
2021-10-08 14:36 ` Michael Albinus
0 siblings, 1 reply; 5+ messages in thread
From: Michael Albinus @ 2021-10-05 14:32 UTC (permalink / raw)
To: Juri Linkov; +Cc: 50976
Juri Linkov <juri@linkov.net> writes:
Hi Juri,
> This is a recent regression. When visiting a remote Dired buffer,
> marking one file with C-SPC (set-mark-command), then moving point
> to another Dired file, then typing '=' (dired-diff) and 'RET'
> fails with the error "Attempt to compare the file to itself".
>
> This is because 'read-file-name' in the interactive spec of 'dired-diff'
> now returns the remote directory name after typing RET,
> while some time ago it correctly returned the default file name,
> that is the marked file that was used as the arg 'file' of 'dired-diff'.
>
> In local filesystems, RET still correctly returns the default file,
> not a directory name as it does now for remote directories.
FTR, git bisect has identified the following guilty commit:
--8<---------------cut here---------------start------------->8---
commit 225ca617b70d3c70376c2d9bf38ced2f2323b26e (refs/bisect/bad)
Author: Michael Albinus <michael.albinus@gmx.de>
Date: Fri Jul 2 14:51:23 2021 +0200
Implement another fix for bug#49229
* lisp/minibuffer.el (read-file-name-default): Respect remote files.
(Bug#49229)
--8<---------------cut here---------------end--------------->8---
I will check how bug#49229 could be fixed differently.
Best regards, Michael.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#50976: 28.0.50; Tramp read-file-name regression
2021-10-05 14:32 ` Michael Albinus
@ 2021-10-08 14:36 ` Michael Albinus
2021-10-23 13:29 ` Michael Albinus
0 siblings, 1 reply; 5+ messages in thread
From: Michael Albinus @ 2021-10-08 14:36 UTC (permalink / raw)
To: Juri Linkov; +Cc: 50976
Michael Albinus <michael.albinus@gmx.de> writes:
Hi Juri,
> I will check how bug#49229 could be fixed differently.
I must confess, w/o a recent build of Emacs 28.0.60 for Windows I cannot
do it :-(
Best regards, Michael.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#50976: 28.0.50; Tramp read-file-name regression
2021-10-08 14:36 ` Michael Albinus
@ 2021-10-23 13:29 ` Michael Albinus
2021-10-23 18:09 ` Juri Linkov
0 siblings, 1 reply; 5+ messages in thread
From: Michael Albinus @ 2021-10-23 13:29 UTC (permalink / raw)
To: Juri Linkov; +Cc: 50976
Michael Albinus <michael.albinus@gmx.de> writes:
Hi Juri,
>> I will check how bug#49229 could be fixed differently.
>
> I must confess, w/o a recent build of Emacs 28.0.60 for Windows I cannot
> do it :-(
Finally, I've managed to install this beast on my MS Windows VM. I've
removed the incrimed patch, and implemented something different. Your
use case now works for me, on both MS Windows and GNU/Linux.
Could you please check?
Best regards, Michael.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#50976: 28.0.50; Tramp read-file-name regression
2021-10-23 13:29 ` Michael Albinus
@ 2021-10-23 18:09 ` Juri Linkov
0 siblings, 0 replies; 5+ messages in thread
From: Juri Linkov @ 2021-10-23 18:09 UTC (permalink / raw)
To: Michael Albinus; +Cc: 50976
close 50976 28.0.60
thanks
Hi Michael,
Thank you for fixing this.
>>> I will check how bug#49229 could be fixed differently.
>>
>> I must confess, w/o a recent build of Emacs 28.0.60 for Windows I cannot
>> do it :-(
>
> Finally, I've managed to install this beast on my MS Windows VM. I've
> removed the incrimed patch, and implemented something different. Your
> use case now works for me, on both MS Windows and GNU/Linux.
>
> Could you please check?
I confirm that now there is no problem anymore on GNU/Linux,
so I'm closing this report (hope that on MS Windows this works too).
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-23 18:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-02 19:19 bug#50976: 28.0.50; Tramp read-file-name regression Juri Linkov
2021-10-05 14:32 ` Michael Albinus
2021-10-08 14:36 ` Michael Albinus
2021-10-23 13:29 ` Michael Albinus
2021-10-23 18:09 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).