unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#54901: 28.1; cl-concatenate void-function error
@ 2022-04-13  4:02 Leo Liu
  2022-04-13  4:10 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Leo Liu @ 2022-04-13  4:02 UTC (permalink / raw)
  To: 54901


Sadly the defun of cl-concatenate is changed to defalias and the bug is
now showing up again in 28.1. Calling cl-concatenate no longer triggers
loading cl-extra.el and its dependency seq.el aka
https://debbugs.gnu.org/45610

The simplest fix is to revert defalias back to defun and put a comment
there.

A further fix can be considered for autoload to handle defalias as
defun, not defvar.

Autoload cookies on defalias forms are tricky. For example (defalias 'a
'b), one needs to make sure B is also available at runtime. We can catch
such a bug if one compiles the generated loaddefs file (I think). But
since they never do it is easy to get wrong.





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#54901: 28.1; cl-concatenate void-function error
  2022-04-13  4:02 bug#54901: 28.1; cl-concatenate void-function error Leo Liu
@ 2022-04-13  4:10 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2022-04-13  4:10 UTC (permalink / raw)
  To: Leo Liu; +Cc: 54901

Leo Liu <sdl.web@gmail.com> writes:

> Sadly the defun of cl-concatenate is changed to defalias and the bug is
> now showing up again in 28.1. Calling cl-concatenate no longer triggers
> loading cl-extra.el and its dependency seq.el aka
> https://debbugs.gnu.org/45610
>
> The simplest fix is to revert defalias back to defun and put a comment
> there.

Yup.  I've now done this on the emacs-28 branch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-13  4:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-13  4:02 bug#54901: 28.1; cl-concatenate void-function error Leo Liu
2022-04-13  4:10 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).