From: Philip Kaludercic <philipk@posteo.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Ken Raeburn <raeburn@redhat.com>, 54406@debbugs.gnu.org
Subject: bug#54406: 28.0.91; rcirc text wrapping
Date: Fri, 04 Nov 2022 22:52:35 +0000 [thread overview]
Message-ID: <871qqil4cs.fsf@posteo.net> (raw)
In-Reply-To: <87r1703jb7.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 17 Mar 2022 11:33:16 +0000")
Philip Kaludercic <philipk@posteo.net> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Ken Raeburn <raeburn@redhat.com> writes:
>>
>>> The old version in 27.1 did:
>>>
>>> ;; squeeze spaces out of text before rcirc-text
>>> (fill-region fill-start
>>> (1- (or (next-single-property-change fill-start
>>> 'rcirc-text)
>>> rcirc-prompt-end-marker)))
>>>
>>> where fill-start is set to
>>>
>>> (marker-position rcirc-prompt-start-marker)
>>>
>>> evaluated before inserting the new text. The new version seems to be
>>> filling the entire narrowed region containing the just-inserted text.
>>
>> So I guess this was changed in:
>>
>> commit 849e71fd83fa8796198035464897bf2f28f6226c
>> Author: Philip Kaludercic <philipk@posteo.net>
>> AuthorDate: Wed Jun 9 17:55:55 2021 +0200
>>
>> I've added Philip to the CCs; perhaps he has some comments.
>
> It seems this was just a misunderstanding on what the "squeeze"-code
> does. The reason it had to be changed is so that messages with
> time-stamps could be received out-of-order. I am guessing (but would
> have to look into it in more detail) that the intention could be
> implemented more elegantly than by calling fill-region on a specific
> region.
The call has been removed with b2283409fbe4324ee2fb50b385a9b6cc3458693c.
Should we close the report or does Ken want to try it out first to
confirm that everything works?
next prev parent reply other threads:[~2022-11-04 22:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 21:11 bug#54406: 28.0.91; rcirc text wrapping Ken Raeburn
[not found] ` <handler.54406.B.164737873611497.ack@debbugs.gnu.org>
2022-03-15 22:24 ` Ken Raeburn
[not found] ` <87h77yc0rt.fsf_-_@redhat.com>
2022-03-17 11:03 ` Lars Ingebrigtsen
2022-03-17 11:33 ` Philip Kaludercic
2022-11-04 22:52 ` Philip Kaludercic [this message]
2023-04-30 10:54 ` Philip Kaludercic
2023-09-14 0:38 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qqil4cs.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=54406@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=raeburn@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).