From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#54406: 28.0.91; rcirc text wrapping Date: Fri, 04 Nov 2022 22:52:35 +0000 Message-ID: <871qqil4cs.fsf@posteo.net> References: <87lexac44t.fsf@redhat.com> <87h77yc0rt.fsf_-_@redhat.com> <8735jgvo12.fsf@gnus.org> <87r1703jb7.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39559"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ken Raeburn , 54406@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 04 23:53:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1or5Z0-000A1w-U6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Nov 2022 23:53:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1or5Yl-0004OK-5C; Fri, 04 Nov 2022 18:53:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1or5Yd-0004Na-SQ for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2022 18:53:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1or5Yb-0003rm-UW for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2022 18:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1or5Yb-0000ph-Qk for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2022 18:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Nov 2022 22:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54406 X-GNU-PR-Package: emacs Original-Received: via spool by 54406-submit@debbugs.gnu.org id=B54406.16676023633172 (code B ref 54406); Fri, 04 Nov 2022 22:53:01 +0000 Original-Received: (at 54406) by debbugs.gnu.org; 4 Nov 2022 22:52:43 +0000 Original-Received: from localhost ([127.0.0.1]:54998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1or5YJ-0000p4-7x for submit@debbugs.gnu.org; Fri, 04 Nov 2022 18:52:43 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:40049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1or5YH-0000oj-MZ for 54406@debbugs.gnu.org; Fri, 04 Nov 2022 18:52:42 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D10A3240104 for <54406@debbugs.gnu.org>; Fri, 4 Nov 2022 23:52:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667602355; bh=JCWR4+8RhaUv4QAgxKlHyhsciCl0N6Sie0Bjm37Larg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=h/YpeOAuuNkXUjpdoZKgPlcN6r2lwsXWZPnQDAMsuaYSaKl3E5S9ksKOgwuRGHhfY qzoNCUasC64X0f69IRf68z3yR/5sQAyxkIwjzJF083Qo6CkMRbjaQnQSsSjeMX9VzD QUOi9uqowkR/T4Dolx7vq6feIYSslzE/f/pEKILFZiT9thWpUeK9Feat3HZGj1y1LW wWaLbOafQSo0frsd+B/APHdCf6J60l73YJfeiFicOynhkhauwQmjAkZwnGTjpmyHhY eBhObdBSpWZfZMP38Im67t/2dZ45ahH7H4JMHhKzocVn+QoUwXo5JM2rVsZHmG/L43 QbgqWiawlO7fw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N3wr30PrCz9rxK; Fri, 4 Nov 2022 23:52:35 +0100 (CET) In-Reply-To: <87r1703jb7.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 17 Mar 2022 11:33:16 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mQGNBGLfygUBDADVznbke6w0n9nE42xb+ZggbBy0IYRkkru/K+NA67523YTl2DoR2a5OMW90w7L9 KDtX2Mp34JN/6jVOSVC07VUbHVu6/exoGKixkiTpGhBPy5tUUJoxQKqLrzVQhN3fIyvg1oyHXKZm QGkUeevV0wjj4++xfjmcP235YvDh3TF8HC9t5KxIQIbhWnQm4ZyDkpWWS2CmdNttlj2+eH+51WLL bgx2bcwTmqrs079Q3hgF3yh44bBEmp9MgFjiZldOY2my0/ZSeucRxYmiM0vbJEBQgZV/MvA3gTxe 7ibV3ii7AyoYA8FiFDP98S/R2y5Nfq3ez9B7qeqtpSNseQHOU7h8Y5VV01a71ZszENAmbbwsldb9 j+HRLke7rn6mswDZl1qA/9ZFRzliFOdQtS1878XjraY+h5jfjvxaFVK23prGGVrrKv0LPWavoFUr nsjeHEZhYezBKhC2PwvRtXm01S3rkNbwm9pj0tfLSDW+1pT+6eZWptfQCXF2oEvgfKSTASUAEQEA AbQmUGhpbGlwIEthbHVkZXJjaWMgPHBoaWxpcGtAcG9zdGVvLm5ldD6JAdQEEwEKAD4WIQRxJuHe LwzjXHcL7QHyw8xRPbifZgUCYt/KBQIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAK CRDyw8xRPbifZkH+DACmCKmhrYgcv2i6dj3vRCVINaLtKUODTna/wAmP20WRKPhqvqvKNUx/wzpT aZrXIxpxOU2xawRWeHhWUktxS+W9L3xTACeR0gf5gomCxD9RuBTIohzWDkQt5rk8QwLqx5rAy5 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247112 Archived-At: Philip Kaludercic writes: > Lars Ingebrigtsen writes: > >> Ken Raeburn writes: >> >>> The old version in 27.1 did: >>> >>> ;; squeeze spaces out of text before rcirc-text >>> (fill-region fill-start >>> (1- (or (next-single-property-change fill-start >>> 'rcirc-text) >>> rcirc-prompt-end-marker))) >>> >>> where fill-start is set to >>> >>> (marker-position rcirc-prompt-start-marker) >>> >>> evaluated before inserting the new text. The new version seems to be >>> filling the entire narrowed region containing the just-inserted text. >> >> So I guess this was changed in: >> >> commit 849e71fd83fa8796198035464897bf2f28f6226c >> Author: Philip Kaludercic >> AuthorDate: Wed Jun 9 17:55:55 2021 +0200 >> >> I've added Philip to the CCs; perhaps he has some comments. > > It seems this was just a misunderstanding on what the "squeeze"-code > does. The reason it had to be changed is so that messages with > time-stamps could be received out-of-order. I am guessing (but would > have to look into it in more detail) that the intention could be > implemented more elegantly than by calling fill-region on a specific > region. The call has been removed with b2283409fbe4324ee2fb50b385a9b6cc3458693c. Should we close the report or does Ken want to try it out first to confirm that everything works?