From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 63311@debbugs.gnu.org
Subject: bug#63311: 30.0.50; [PATCH] smtpmail-send-it split
Date: Wed, 10 May 2023 13:47:11 +0200 [thread overview]
Message-ID: <871qjoe7cw.fsf@ledu-giraud.fr> (raw)
In-Reply-To: <87wn1hzv9j.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Tue, 09 May 2023 11:52:56 +0200")
Hi Eli,
My strategy after the previous patch is summed up by this function:
--8<---------------cut here---------------start------------->8---
(defun smtpmail-async-send-it (cleanups)
(let ((tembuf (generate-new-buffer " smtpmail temp"))
(smtpmail-code-conv-from
(if enable-multibyte-characters
(let ((sendmail-coding-system smtpmail-code-conv-from))
(select-message-coding-system)))))
(smtpmail-prepare-mail tembuf smtpmail-code-conv-from)
(push #'(lambda () (kill-buffer tembuf)) cleanups)
(make-thread #'(lambda ()
(smtpmail-send-mail tembuf)
(mapc #'funcall cleanups)))))
--8<---------------cut here---------------end--------------->8---
That is, I'd like carry around a 'cleanups' list that holds all the
functions that needed to be called after the mail was sent.
I then need to propagate this 'cleanups' parameter to callers of
'smtpmail-send-it'. The problem is that encounter code with the
following form:
--8<---------------cut here---------------start------------->8---
(unwind-protect
(let (haha)
(do)
(many)
(things)
(smtpmail-send-it-or-one-of-its-caller)
(run)
(other)
(stuff))
(kill-some-top-level-buffer))
--8<---------------cut here---------------end--------------->8---
I'm tempted to put '(run)(other)(stuff)(kill-some-top-level-buffer)'
into the cleanups list and remove the unwind-protect but then if
something goes wrong before sending the mail the
'(kill-some-top-level-buffer)' part won't be called. OTOH, if I let the
'(unwind-protect… (kill-some-top-level-buffer)' in place I could shoot
myself in the foot with the code that use this buffer into the thread.
So I guess, my question is how does one mix Lisp thread with
unwind-protect?
Best regards,
--
Manuel Giraud
next prev parent reply other threads:[~2023-05-10 11:47 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 13:13 bug#63311: 30.0.50; [PATCH] smtpmail-send-it split Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-05 18:57 ` Eli Zaretskii
[not found] ` <874joq34bk.fsf@ledu-giraud.fr>
2023-05-06 6:20 ` Eli Zaretskii
2023-05-06 9:34 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-09 9:52 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-10 11:47 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-05-11 13:28 ` Eli Zaretskii
2023-05-11 20:59 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-12 5:41 ` Eli Zaretskii
2023-05-12 6:24 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-12 7:09 ` Eli Zaretskii
2023-05-12 7:57 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-01 12:35 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-01 12:59 ` Eli Zaretskii
2023-11-01 18:06 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-01 19:29 ` Eli Zaretskii
2023-11-01 19:55 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-02 5:48 ` Eli Zaretskii
2023-11-02 10:44 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-02 11:26 ` Eli Zaretskii
2023-11-05 14:24 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-05 15:46 ` Eli Zaretskii
2023-11-05 16:12 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-05 16:17 ` Eli Zaretskii
2023-11-06 10:21 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-06 12:40 ` Eli Zaretskii
2023-11-06 15:56 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-06 16:28 ` Eli Zaretskii
2023-11-06 17:57 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-06 19:21 ` Eli Zaretskii
2023-11-06 20:55 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-07 3:26 ` Eli Zaretskii
2023-11-07 9:06 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-07 12:12 ` Eli Zaretskii
2023-11-07 12:56 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-07 13:17 ` Eli Zaretskii
2023-11-03 2:31 ` Richard Stallman
2023-11-03 7:18 ` Eli Zaretskii
2023-11-03 13:49 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-03 14:29 ` Eli Zaretskii
2023-05-12 7:10 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qjoe7cw.fsf@ledu-giraud.fr \
--to=bug-gnu-emacs@gnu.org \
--cc=63311@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).