From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63311: 30.0.50; [PATCH] smtpmail-send-it split Date: Wed, 10 May 2023 13:47:11 +0200 Message-ID: <871qjoe7cw.fsf@ledu-giraud.fr> References: <87jzxmsyyr.fsf@ledu-giraud.fr> <83ttwqhahy.fsf@gnu.org> <874joq34bk.fsf@ledu-giraud.fr> <83o7mygevr.fsf@gnu.org> <87wn1hzv9j.fsf@ledu-giraud.fr> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5365"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 63311@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 10 13:48:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwiIu-00018m-Rx for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 May 2023 13:48:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwiIf-0004is-CW; Wed, 10 May 2023 07:48:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwiIc-0004ia-SU for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 07:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwiIc-0000MK-KT for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 07:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwiIc-0002Wh-Gh for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 07:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 May 2023 11:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63311 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63311-submit@debbugs.gnu.org id=B63311.16837192399508 (code B ref 63311); Wed, 10 May 2023 11:48:02 +0000 Original-Received: (at 63311) by debbugs.gnu.org; 10 May 2023 11:47:19 +0000 Original-Received: from localhost ([127.0.0.1]:45416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwiHu-0002TI-UC for submit@debbugs.gnu.org; Wed, 10 May 2023 07:47:19 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:31282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwiHq-0002T4-Kv for 63311@debbugs.gnu.org; Wed, 10 May 2023 07:47:18 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=47OcNKKi q2TcJtDlE4ysxolI6y6BzPDEZtU+QgNTT5s=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=CJu11UiJ8WXJGDz0iDH0k/bEY44zTu Y5PR5sSbmO+CzTdzdDq1Mwuo878rhzFMvaccHHnOKaQ+JcgolN5Ni8AA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=47OcNKKiq2TcJtDl E4ysxolI6y6BzPDEZtU+QgNTT5s=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=TDYOpt1o/sW18EMfOkGzsGp/fb8dk9mWAb4Gnd Ox9gR1WIG6xRxaPYCEX9WHRftuRW9wHO/GZLyS55NhGx+AmvVmxUrVuDOyEe4yFQV1mOGP zNWAw+llEnpqKVccdTuR/LOsqxXa5nDXH9OrxgLmLB//GGMD+sEQZQSvNq2GaAReEV2Opa RONYsoctRM3sqHtWUzz3Hgl9mJ9uy6j7jESE7g7wDqsft239xJS4L+BP1R668MRIRvL9rx 4eqzbajD4gyy0L0GnmAwMEWEjXN1z0PFFccF8q33Wkkn/hQMkPgPAdJijrU1b0QKG+J8/8 7LtiE+JWyhUkbOcvpcr3vQOg== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id ef4a89a5 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 10 May 2023 13:47:12 +0200 (CEST) In-Reply-To: <87wn1hzv9j.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Tue, 09 May 2023 11:52:56 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261485 Archived-At: Hi Eli, My strategy after the previous patch is summed up by this function: --8<---------------cut here---------------start------------->8--- (defun smtpmail-async-send-it (cleanups) (let ((tembuf (generate-new-buffer " smtpmail temp")) (smtpmail-code-conv-from (if enable-multibyte-characters (let ((sendmail-coding-system smtpmail-code-conv-from)) (select-message-coding-system))))) (smtpmail-prepare-mail tembuf smtpmail-code-conv-from) (push #'(lambda () (kill-buffer tembuf)) cleanups) (make-thread #'(lambda () (smtpmail-send-mail tembuf) (mapc #'funcall cleanups))))) --8<---------------cut here---------------end--------------->8--- That is, I'd like carry around a 'cleanups' list that holds all the functions that needed to be called after the mail was sent. I then need to propagate this 'cleanups' parameter to callers of 'smtpmail-send-it'. The problem is that encounter code with the following form: --8<---------------cut here---------------start------------->8--- (unwind-protect (let (haha) (do) (many) (things) (smtpmail-send-it-or-one-of-its-caller) (run) (other) (stuff)) (kill-some-top-level-buffer)) --8<---------------cut here---------------end--------------->8--- I'm tempted to put '(run)(other)(stuff)(kill-some-top-level-buffer)' into the cleanups list and remove the unwind-protect but then if something goes wrong before sending the mail the '(kill-some-top-level-buffer)' part won't be called. OTOH, if I let the '(unwind-protect=E2=80=A6 (kill-some-top-level-buffer)' in place I could s= hoot myself in the foot with the code that use this buffer into the thread. So I guess, my question is how does one mix Lisp thread with unwind-protect? Best regards, --=20 Manuel Giraud