From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
63455@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing
Date: Fri, 12 May 2023 20:16:20 +0300 [thread overview]
Message-ID: <86zg69lb6v.fsf@mail.linkov.net> (raw)
In-Reply-To: <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> (martin rudalics's message of "Fri, 12 May 2023 09:39:40 +0200")
> I think you're right. In my local Emacs I removed both incarnations of
> that code (the other one being in 'display-buffer--maybe-at-bottom')
> long ago.
There are 3 uses of 'display-buffer--maybe-at-bottom' in the Emacs
source tree: 'project-kill-buffers' and 'save-buffers-kill-emacs'
override the default. But 'hack-local-variables-confirm'
depends on the current default value.
> I can only shortly sketch how I manage things here: The end
> of 'help--window-setup' has become
>
> (help-window-setup
> (setq window (temp-buffer-window-show (current-buffer) nil t)))
> (help-make-xrefs (current-buffer))
> (when (and window temp-buffer-resize-mode)
> (let (resize-temp-buffer-window-inhibit)
> (resize-temp-buffer-window window)))))))
>
> 'temp-buffer-window-show' has a third argument NO-RESIZE and its last
> lines are rewritten as
>
> (with-selected-window window
> (run-hooks 'temp-buffer-window-show-hook)
> (when (and (not no-resize) temp-buffer-resize-mode)
> (resize-temp-buffer-window window)))
> ;; Return the window.
> window))))
>
> Maybe Juri can make heads or tails of this.
Are these changes intended to completely remove these lines from
'display-buffer-in-direction' and 'display-buffer--maybe-at-bottom'?
`(,(if temp-buffer-resize-mode
'(window-height . resize-temp-buffer-window)
'(window-height . fit-window-to-buffer))
,(when temp-buffer-resize-mode
'(preserve-size . (nil . t))))
I expected that only 1 line should be removed to change this to:
`(,(when temp-buffer-resize-mode
'(window-height . resize-temp-buffer-window))
,(when temp-buffer-resize-mode
'(preserve-size . (nil . t))))
But if all lines should be removed, then how to use it?
I tried with your patch, but this doesn't resize the window:
(setq temp-buffer-resize-mode t)
(display-buffer (current-buffer)
'((display-buffer-in-direction) . ((direction . top))))
next prev parent reply other threads:[~2023-05-12 17:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 1:06 bug#63455: 30.0.50; display-buffer-in-direction is always resizing Michael Heerdegen
2023-05-12 7:39 ` martin rudalics
2023-05-12 17:16 ` Juri Linkov [this message]
2023-05-13 8:56 ` martin rudalics
2023-05-15 17:01 ` Juri Linkov
2023-05-15 18:21 ` Eli Zaretskii
2023-05-16 7:19 ` martin rudalics
2023-05-16 16:35 ` Juri Linkov
2023-05-17 16:56 ` Juri Linkov
2023-05-18 8:29 ` martin rudalics
2023-05-18 15:54 ` Juri Linkov
2023-05-19 7:31 ` martin rudalics
2023-05-19 17:54 ` Juri Linkov
2023-05-20 8:27 ` martin rudalics
2023-05-22 18:03 ` Juri Linkov
2023-05-23 2:30 ` Michael Heerdegen
2023-05-23 18:25 ` Juri Linkov
2023-05-24 2:48 ` Michael Heerdegen
2023-05-12 17:11 ` Juri Linkov
2023-05-13 5:29 ` Michael Heerdegen
2023-05-15 17:02 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zg69lb6v.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=63455@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=michael_heerdegen@web.de \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).