unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Juri Linkov <juri@linkov.net>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
	63455@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing
Date: Fri, 19 May 2023 09:31:05 +0200	[thread overview]
Message-ID: <334ee702-f627-ce8b-ccb2-d0b7c4251c3f@gmx.at> (raw)
In-Reply-To: <86v8gp1voz.fsf@mail.linkov.net>

 > This function should be added instead of your changes in
 > help--window-setup and temp-buffer-window-show?

IIRC 'help--window-setup' wants us to (1) show the window via
'display-buffer' (2) call 'help-make-xrefs' which may change the buffer
size and (3) only then fit the window to the buffer, something "this
function" cannot accomplish.  BTW, this is a special case the NO-RESIZE
argument might not handle correctly in the queer case where a user has
'temp-buffer-resize-mode' enabled but does _not_ want to fit help
windows to their buffer and added a special rule for *Help* buffers.

So conceptually "this function" should be used only in functions like
'hack-local-variables-confirm' where we do something temporary buffer
likish without calling 'with-temp-buffer-window' explicitly.

martin





  reply	other threads:[~2023-05-19  7:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12  1:06 bug#63455: 30.0.50; display-buffer-in-direction is always resizing Michael Heerdegen
2023-05-12  7:39 ` martin rudalics
2023-05-12 17:16   ` Juri Linkov
2023-05-13  8:56     ` martin rudalics
2023-05-15 17:01       ` Juri Linkov
2023-05-15 18:21         ` Eli Zaretskii
2023-05-16  7:19         ` martin rudalics
2023-05-16 16:35           ` Juri Linkov
2023-05-17 16:56   ` Juri Linkov
2023-05-18  8:29     ` martin rudalics
2023-05-18 15:54       ` Juri Linkov
2023-05-19  7:31         ` martin rudalics [this message]
2023-05-19 17:54       ` Juri Linkov
2023-05-20  8:27         ` martin rudalics
2023-05-22 18:03           ` Juri Linkov
2023-05-23  2:30             ` Michael Heerdegen
2023-05-23 18:25               ` Juri Linkov
2023-05-24  2:48                 ` Michael Heerdegen
2023-05-12 17:11 ` Juri Linkov
2023-05-13  5:29   ` Michael Heerdegen
2023-05-15 17:02     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=334ee702-f627-ce8b-ccb2-d0b7c4251c3f@gmx.at \
    --to=rudalics@gmx.at \
    --cc=63455@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=juri@linkov.net \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).