unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Ergus <spacibba@aol.com>, 53910@debbugs.gnu.org
Subject: bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers
Date: Thu, 10 Feb 2022 10:54:29 +0200	[thread overview]
Message-ID: <86y22jxfsq.fsf@mail.linkov.net> (raw)
In-Reply-To: <87mtizdwrv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 10 Feb 2022 08:08:04 +0100")

>> M-x context-menu-mode
>> C-h b
>>
>> Just a message is shown in the echo area like an error because the
>> buffer is read only (and such text can't be inserted...).
>
> I can reproduce this bug, and I can't get a backtrace either, even with
> debug-on-signal, which is unusual.
>
> I had a brief peek at context-menu-mode to see whether it was obvious
> what was breaking, but nothing really stood out (but then again, I'm not
> very familiar with that code).

I can't reproduce this bug in Emacs 28, only in Emacs 29.
This means that the problem is new.  In describe-map
this line switches buffers from *Help* to the window buffer:

  (eq definition (lookup-key tail (vector event) t))

And indeed

  (with-temp-buffer
    (message "%S" (current-buffer))
    (lookup-key (cddr context-menu-mode-map) [down-mouse-3] t)
    (message "%S" (current-buffer)))

displays:

  #<buffer  *temp*>
  #<buffer *scratch*>

This is because of this line recently added to context-menu-map:

  (select-window (posn-window (event-start click)))

that switches buffers.

But the question remains: does describe-map really need to build
the complete context menu or should it ignore its :filter keyword?





  reply	other threads:[~2022-02-10  8:54 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus>
2022-02-10  0:16 ` bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-10  7:08   ` Lars Ingebrigtsen
2022-02-10  8:54     ` Juri Linkov [this message]
2022-02-10 11:35       ` Lars Ingebrigtsen
2022-02-10 18:58         ` Juri Linkov
2022-02-11  8:31           ` martin rudalics
2022-02-11  8:40             ` Juri Linkov
2022-02-11 16:46               ` bug#53910: [External] : " Drew Adams
2022-02-12 17:05                 ` Juri Linkov
2022-02-13  8:49                   ` martin rudalics
2022-02-13 18:50                     ` Juri Linkov
2022-02-17 19:13                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-17 19:30                         ` Juri Linkov
2022-02-17 20:12                           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-18  7:44                             ` Juri Linkov
2022-02-18  8:32                               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-20 18:56                                 ` Juri Linkov
2022-02-19  9:41                           ` martin rudalics
2022-02-19 12:26                             ` Eli Zaretskii
2022-02-19 17:07                               ` martin rudalics
2022-02-19 17:22                                 ` Eli Zaretskii
2022-02-20  9:16                                   ` martin rudalics
2022-02-20 18:44                                     ` Juri Linkov
2022-02-21  9:07                                       ` martin rudalics
2022-02-22 17:10                                         ` Juri Linkov
2022-02-23  9:29                                           ` martin rudalics
2022-02-19 14:38                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-20  9:14                               ` martin rudalics
2022-02-20 14:42                                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-10  8:26   ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y22jxfsq.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=53910@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).