From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, juri@linkov.net, 53910@debbugs.gnu.org,
monnier@iro.umontreal.ca, spacibba@aol.com
Subject: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers
Date: Sun, 20 Feb 2022 10:16:57 +0100 [thread overview]
Message-ID: <70c9a41a-4205-bc13-48c9-86dce0d2a4e9@gmx.at> (raw)
In-Reply-To: <83y226ydnn.fsf@gnu.org>
> That bury-buffer can be mis-used or abused
Do you mean that the functions I posted mis-use or abuse 'bury-buffer'?
> doesn't mean it should not
> be used correctly,
What distinguishes a "correct use" of 'bury-buffer' from an "incorrect"
one in your opinion?
> especially since we do that in many places.
Many of those assign 'bury-buffer' to a key (which is perfectly valid)
or call it with an explicit BUFFER-OR-NAME argument (which is also valid
but could avoid the extra indirection by calling 'bury-buffer-internal'
right away). Problematic are calls without arguments, especially when
they are wrapped in 'with-selected-window' like in 'tab-line-close-tab'.
> Moreover, bury-buffer does little besides bury-buffer-internal, so I
> still don't understand the emotional reaction.
What's emotional about a recommendation? My
I recommend against calling 'bury-buffer' in Lisp code:
has to be seen in the context of Juri's
Maybe (kill-buffer (window-buffer <WINDOW>)) has the same effect
when used in any window, but (bury-buffer (window-buffer <WINDOW>))
definitely should be called in the required window, because `bury-buffer`
uses `nil` for the WINDOW args, e.g.:
(set-window-dedicated-p nil nil)
(switch-to-prev-buffer nil 'bury)
martin
next prev parent reply other threads:[~2022-02-20 9:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus>
2022-02-10 0:16 ` bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-10 7:08 ` Lars Ingebrigtsen
2022-02-10 8:54 ` Juri Linkov
2022-02-10 11:35 ` Lars Ingebrigtsen
2022-02-10 18:58 ` Juri Linkov
2022-02-11 8:31 ` martin rudalics
2022-02-11 8:40 ` Juri Linkov
2022-02-11 16:46 ` bug#53910: [External] : " Drew Adams
2022-02-12 17:05 ` Juri Linkov
2022-02-13 8:49 ` martin rudalics
2022-02-13 18:50 ` Juri Linkov
2022-02-17 19:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-17 19:30 ` Juri Linkov
2022-02-17 20:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-18 7:44 ` Juri Linkov
2022-02-18 8:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-20 18:56 ` Juri Linkov
2022-02-19 9:41 ` martin rudalics
2022-02-19 12:26 ` Eli Zaretskii
2022-02-19 17:07 ` martin rudalics
2022-02-19 17:22 ` Eli Zaretskii
2022-02-20 9:16 ` martin rudalics [this message]
2022-02-20 18:44 ` Juri Linkov
2022-02-21 9:07 ` martin rudalics
2022-02-22 17:10 ` Juri Linkov
2022-02-23 9:29 ` martin rudalics
2022-02-19 14:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-20 9:14 ` martin rudalics
2022-02-20 14:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-10 8:26 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70c9a41a-4205-bc13-48c9-86dce0d2a4e9@gmx.at \
--to=rudalics@gmx.at \
--cc=53910@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).