From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 54038@debbugs.gnu.org
Subject: bug#54038: 29.0.50; doc-view cannot show different pages in different tabs
Date: Sat, 19 Feb 2022 19:35:33 +0200 [thread overview]
Message-ID: <86y226wyea.fsf@mail.linkov.net> (raw)
In-Reply-To: <86wnhslhli.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 18 Feb 2022 10:11:21 +0200")
> The problem is that when 'image-mode-winprops' does window cleanup,
> it doesn't take into account windows saved in tabs.
The current implementation:
(when cleanup
(setq image-mode-winprops-alist
(delq nil (mapcar (lambda (winprop)
(let ((w (car-safe winprop)))
(if (or (not (windowp w)) (window-live-p w))
winprop)))
image-mode-winprops-alist))))
'window-live-p' doesn't check windows saved in window-configurations in tabs.
Maybe it should check tab window-configurations on all frames
by a new function 'window-configuration-windows'
(something like used in 'tab-bar-get-buffer-tab').
But then what about windows saved by 'window-configuration-to-register'?
Should they be checked by 'window-live-p' too?
Or maybe better to change 'image-mode-winprops-alist' to the hash
'image-mode-winprops-hash' where window keys are garbage-collected?
So when a window is deleted from all window-configurations,
it will be garbage-collected?
next prev parent reply other threads:[~2022-02-19 17:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 9:18 bug#54038: 29.0.50; doc-view cannot show different pages in different tabs Visuwesh
2022-02-17 18:12 ` Juri Linkov
2022-02-18 1:06 ` Visuwesh
2022-02-18 7:46 ` Juri Linkov
2022-02-19 17:31 ` Juri Linkov
2022-02-20 9:17 ` martin rudalics
2022-02-23 17:59 ` Juri Linkov
2022-02-18 8:11 ` Juri Linkov
2022-02-18 12:19 ` Visuwesh
2022-02-19 17:35 ` Juri Linkov [this message]
2022-02-20 9:17 ` martin rudalics
2022-02-20 18:51 ` Juri Linkov
2022-02-21 9:08 ` martin rudalics
2022-02-23 17:46 ` Juri Linkov
2022-02-24 9:18 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y226wyea.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=54038@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).