From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#54038: 29.0.50; doc-view cannot show different pages in different tabs Date: Sat, 19 Feb 2022 19:35:33 +0200 Organization: LINKOV.NET Message-ID: <86y226wyea.fsf@mail.linkov.net> References: <874k4xrgu5.fsf@gmail.com> <86wnhtjrb4.fsf@mail.linkov.net> <87fsohouaw.fsf@gmail.com> <86wnhslhli.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32623"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 54038@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 19 18:42:47 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLTkt-0008L2-KO for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Feb 2022 18:42:47 +0100 Original-Received: from localhost ([::1]:37578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLTkr-0003SV-Uk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Feb 2022 12:42:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLTkK-0003SC-19 for bug-gnu-emacs@gnu.org; Sat, 19 Feb 2022 12:42:12 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36555) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nLTkA-0004HM-Ds for bug-gnu-emacs@gnu.org; Sat, 19 Feb 2022 12:42:11 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nLTkA-0003cI-8J for bug-gnu-emacs@gnu.org; Sat, 19 Feb 2022 12:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Feb 2022 17:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54038 X-GNU-PR-Package: emacs Original-Received: via spool by 54038-submit@debbugs.gnu.org id=B54038.164529251013868 (code B ref 54038); Sat, 19 Feb 2022 17:42:02 +0000 Original-Received: (at 54038) by debbugs.gnu.org; 19 Feb 2022 17:41:50 +0000 Original-Received: from localhost ([127.0.0.1]:58684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLTjy-0003bX-EW for submit@debbugs.gnu.org; Sat, 19 Feb 2022 12:41:50 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:51243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLTjw-0003bA-Sw for 54038@debbugs.gnu.org; Sat, 19 Feb 2022 12:41:49 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id B3CCE60005; Sat, 19 Feb 2022 17:41:42 +0000 (UTC) In-Reply-To: <86wnhslhli.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 18 Feb 2022 10:11:21 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227200 Archived-At: > The problem is that when 'image-mode-winprops' does window cleanup, > it doesn't take into account windows saved in tabs. The current implementation: (when cleanup (setq image-mode-winprops-alist (delq nil (mapcar (lambda (winprop) (let ((w (car-safe winprop))) (if (or (not (windowp w)) (window-live-p w)) winprop))) image-mode-winprops-alist)))) 'window-live-p' doesn't check windows saved in window-configurations in tabs. Maybe it should check tab window-configurations on all frames by a new function 'window-configuration-windows' (something like used in 'tab-bar-get-buffer-tab'). But then what about windows saved by 'window-configuration-to-register'? Should they be checked by 'window-live-p' too? Or maybe better to change 'image-mode-winprops-alist' to the hash 'image-mode-winprops-hash' where window keys are garbage-collected? So when a window is deleted from all window-configurations, it will be garbage-collected?