From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 55169@debbugs.gnu.org
Subject: bug#55169: Can't combine window-min-height with window-height
Date: Fri, 06 May 2022 10:52:44 +0300 [thread overview]
Message-ID: <86v8ujcd2r.fsf@mail.linkov.net> (raw)
In-Reply-To: <b5f29a3a-5616-a5f0-8800-88cf834f59a7@gmx.at> (martin rudalics's message of "Fri, 6 May 2022 09:02:51 +0200")
>> Because it should be the task of fit-window-to-buffer,
>> and it already has the argument MIN-HEIGHT.
>> Also other arguments of fit-window-to-buffer
>> could be allowed to use in display-buffer-alist.
>
> You mean the value of a 'window-height' entry could also be a
>
> • A list whose CAR is a function and whose remaining elements
> are the arguments passed to that function.
>
> so we'd run
>
> (ignore-errors (funcall (car height) window (nth 1 height) ...))
>
> in 'window--display-buffer'? Which means the caller has to know the
> function and which arguments it needs in which order. Sounds fragile.
It is intended only for special handling of 'fit-window-to-buffer'.
If 'fit-window-to-buffer' with MIN-HEIGHT will really fix this problem,
then details of the entry format could be adapted later.
And indeed this works exactly as should with
(pop-to-buffer (generate-new-buffer "*edit string*")
'(display-buffer-below-selected
(window-height . fit-window-to-buffer)))
and an experimental patch:
diff --git a/lisp/window.el b/lisp/window.el
index 9f78784612..a21cf109a4 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -7336,7 +7336,9 @@ window--display-buffer
(window-resize window delta nil 'safe t)))
(setq resize-temp-buffer-window-inhibit 'vertical))
((functionp height)
- (ignore-errors (funcall height window))
+ (if (eq height 'fit-window-to-buffer)
+ (ignore-errors (funcall height window nil 10))
+ (ignore-errors (funcall height window)))
(setq resize-temp-buffer-window-inhibit 'vertical)))
;; Adjust width of window if asked for.
(cond
next prev parent reply other threads:[~2022-05-06 7:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 17:58 bug#55169: Can't combine window-min-height with window-height Juri Linkov
2022-04-29 10:27 ` Lars Ingebrigtsen
2022-04-30 8:03 ` martin rudalics
2022-05-01 17:06 ` Juri Linkov
2022-05-02 7:37 ` martin rudalics
2022-05-02 18:53 ` Juri Linkov
2022-05-03 9:21 ` martin rudalics
2022-05-03 17:38 ` Juri Linkov
2022-05-04 7:54 ` martin rudalics
2022-05-04 19:29 ` Juri Linkov
2022-05-05 7:47 ` martin rudalics
2022-05-05 8:03 ` Juri Linkov
2022-05-05 9:49 ` martin rudalics
2022-05-05 16:37 ` Juri Linkov
2022-05-06 7:02 ` martin rudalics
2022-05-06 7:52 ` Juri Linkov [this message]
2022-05-06 14:10 ` martin rudalics
2022-05-06 15:34 ` Juri Linkov
2022-05-07 7:58 ` martin rudalics
2022-05-08 18:18 ` Juri Linkov
2022-05-09 7:24 ` martin rudalics
2022-05-09 7:38 ` martin rudalics
2022-05-09 18:58 ` Juri Linkov
2022-05-10 7:41 ` martin rudalics
2022-05-11 7:21 ` Juri Linkov
2022-05-11 8:19 ` martin rudalics
2022-05-12 17:03 ` Juri Linkov
2022-05-13 7:01 ` martin rudalics
2022-05-13 16:58 ` Juri Linkov
2022-05-14 7:49 ` martin rudalics
2022-05-11 9:03 ` Richard Stallman
2022-05-12 16:59 ` Juri Linkov
2022-05-18 18:20 ` Juri Linkov
2022-05-19 7:18 ` martin rudalics
2022-05-19 16:27 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86v8ujcd2r.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=55169@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).