From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 55169@debbugs.gnu.org
Subject: bug#55169: Can't combine window-min-height with window-height
Date: Sun, 08 May 2022 21:18:28 +0300 [thread overview]
Message-ID: <86mtfrj3bh.fsf@mail.linkov.net> (raw)
In-Reply-To: <e85c502a-892d-9dda-786f-790f67f9715d@gmx.at> (martin rudalics's message of "Sat, 7 May 2022 09:58:48 +0200")
>> (pop-to-buffer (generate-new-buffer "*edit string*")
>> '(display-buffer-below-selected
>> (window-height . (lambda (window)
>> (fit-window-to-buffer window nil 10)))))
>
> Sounds too complicated IMO.
Actually a lambda is already supported, so no changes are required.
> Let's stick to your earlier proposal as
>
> (ignore-errors
> (if (eq height 'fit-window-to-buffer)
> (fit-window-to-buffer
> window nil (cdr (assq 'window-min-height alist)))
> (funcall height window)))
>
> say something like "As a special case, if `window-height' specifies
> `fit-window-to-buffer' and ALIST contains a `window-min-height' entry,
> pass the value of that entry as MIN-HEIGHT argument to
> `fit-window-to-buffer'." and do a similar thing for `window-min-width'.
A special case for fit-window-to-buffer, shrink-window-* and other similar
could be implemented only when you are sure that a `window-min-height' entry
is not going to be used for other purposes besides of using it as an argument
of a window-height entry.
BTW, fit-window-to-buffer has also other arguments: MAX-WIDTH and MIN-WIDTH.
Would they be useful for a window-width entry?
> And if we really want to, we can always add a MIN-HEIGHT argument to
> 'shrink-window-if-larger-than-buffer' and handle it the same way.
This is very much needed, thanks.
next prev parent reply other threads:[~2022-05-08 18:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 17:58 bug#55169: Can't combine window-min-height with window-height Juri Linkov
2022-04-29 10:27 ` Lars Ingebrigtsen
2022-04-30 8:03 ` martin rudalics
2022-05-01 17:06 ` Juri Linkov
2022-05-02 7:37 ` martin rudalics
2022-05-02 18:53 ` Juri Linkov
2022-05-03 9:21 ` martin rudalics
2022-05-03 17:38 ` Juri Linkov
2022-05-04 7:54 ` martin rudalics
2022-05-04 19:29 ` Juri Linkov
2022-05-05 7:47 ` martin rudalics
2022-05-05 8:03 ` Juri Linkov
2022-05-05 9:49 ` martin rudalics
2022-05-05 16:37 ` Juri Linkov
2022-05-06 7:02 ` martin rudalics
2022-05-06 7:52 ` Juri Linkov
2022-05-06 14:10 ` martin rudalics
2022-05-06 15:34 ` Juri Linkov
2022-05-07 7:58 ` martin rudalics
2022-05-08 18:18 ` Juri Linkov [this message]
2022-05-09 7:24 ` martin rudalics
2022-05-09 7:38 ` martin rudalics
2022-05-09 18:58 ` Juri Linkov
2022-05-10 7:41 ` martin rudalics
2022-05-11 7:21 ` Juri Linkov
2022-05-11 8:19 ` martin rudalics
2022-05-12 17:03 ` Juri Linkov
2022-05-13 7:01 ` martin rudalics
2022-05-13 16:58 ` Juri Linkov
2022-05-14 7:49 ` martin rudalics
2022-05-11 9:03 ` Richard Stallman
2022-05-12 16:59 ` Juri Linkov
2022-05-18 18:20 ` Juri Linkov
2022-05-19 7:18 ` martin rudalics
2022-05-19 16:27 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86mtfrj3bh.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=55169@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).