bug#51768: 29.0.50; User font settings are ignored (Win10)

bug#51768: 29.0.50; User font settings are ignored (Win10)

[Arash Esbati]

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]

Hi all,

I've customized my fonts like this:

(custom-set-faces
 ;; custom-set-faces was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 '(default ((t (:family "Source Code Pro Medium" :foundry "outline" :slant normal :weight medium :height 90 :width normal))))
 '(fixed-pitch ((t (:inherity default)))))

Emacs from master (3e23494394) ignores these settings and starts with
Arial which looks likte this:

[-- Attachment #2: arial.png --]
[-- Type: image/png, Size: 11935 bytes --]

[-- Attachment #3: Type: text/plain, Size: 169 bytes --]


My last build (41b1fa05c7) works as expected.  To reproduce:

1) Make a minimal init file with the code above
2) Start emacs

This is on Win10 with Msys2.

Best, Arash

bug#51768: 29.0.50; User font settings are ignored (Win10)

[Arash Esbati]

Arash Esbati <arash@gnu.org> writes:

> I've customized my fonts like this:
>
> (custom-set-faces
>  ;; custom-set-faces was added by Custom.
>  ;; If you edit it by hand, you could mess it up, so be careful.
>  ;; Your init file should contain only one such instance.
>  ;; If there is more than one, they won't work right.
>  '(default ((t (:family "Source Code Pro Medium" :foundry "outline"
> :slant normal :weight medium :height 90 :width normal))))
>  '(fixed-pitch ((t (:inherity default)))))

Sorry, there is a typo in :inherit -- finger trouble while yanking.  It
should read:

(custom-set-faces
 ;; custom-set-faces was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 '(default ((t (:family "Source Code Pro Medium" :foundry "outline" :slant normal :weight medium :height 90 :width normal))))
 '(fixed-pitch ((t (:inherit default)))))

The behavior remains.

bug#51768: 29.0.50; User font settings are ignored (Win10)

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Date: Thu, 11 Nov 2021 16:18:32 +0100
> 
> (custom-set-faces
>  ;; custom-set-faces was added by Custom.
>  ;; If you edit it by hand, you could mess it up, so be careful.
>  ;; Your init file should contain only one such instance.
>  ;; If there is more than one, they won't work right.
>  '(default ((t (:family "Source Code Pro Medium" :foundry "outline" :slant normal :weight medium :height 90 :width normal))))
>  '(fixed-pitch ((t (:inherity default)))))
> 
> Emacs from master (3e23494394) ignores these settings and starts with
> Arial which looks likte this:

If you revert commit 32086ea23, does the problem go away?

bug#51768: 29.0.50; User font settings are ignored (Win10)

[Arash Esbati]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Arash Esbati <arash@gnu.org>
>> Date: Thu, 11 Nov 2021 16:18:32 +0100
>> 
>> (custom-set-faces
>>  ;; custom-set-faces was added by Custom.
>>  ;; If you edit it by hand, you could mess it up, so be careful.
>>  ;; Your init file should contain only one such instance.
>>  ;; If there is more than one, they won't work right.
>>  '(default ((t (:family "Source Code Pro Medium" :foundry "outline"
>> :slant normal :weight medium :height 90 :width normal))))
>>  '(fixed-pitch ((t (:inherity default)))))
>> 
>> Emacs from master (3e23494394) ignores these settings and starts with
>> Arial which looks likte this:
>
> If you revert commit 32086ea23, does the problem go away?

Yes, it does.  I did

  git checkout a491b73c765adde894acdbafc6fd97edd4343c2c

and built again.  Font settings are respected.

Best, Arash

bug#51768: 29.0.50; User font settings are ignored (Win10)

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Cc: 51768@debbugs.gnu.org
> Date: Thu, 11 Nov 2021 18:52:30 +0100
> 
> >> (custom-set-faces
> >>  ;; custom-set-faces was added by Custom.
> >>  ;; If you edit it by hand, you could mess it up, so be careful.
> >>  ;; Your init file should contain only one such instance.
> >>  ;; If there is more than one, they won't work right.
> >>  '(default ((t (:family "Source Code Pro Medium" :foundry "outline"
> >> :slant normal :weight medium :height 90 :width normal))))
> >>  '(fixed-pitch ((t (:inherity default)))))
> >> 
> >> Emacs from master (3e23494394) ignores these settings and starts with
> >> Arial which looks likte this:
> >
> > If you revert commit 32086ea23, does the problem go away?
> 
> Yes, it does.  I did
> 
>   git checkout a491b73c765adde894acdbafc6fd97edd4343c2c
> 
> and built again.  Font settings are respected.

Where did you download this font, and which files exactly did you
download for it?

bug#51768: 29.0.50; User font settings are ignored (Win10)

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Cc: 51768@debbugs.gnu.org
> Date: Thu, 11 Nov 2021 18:52:30 +0100
> 
> >> (custom-set-faces
> >>  ;; custom-set-faces was added by Custom.
> >>  ;; If you edit it by hand, you could mess it up, so be careful.
> >>  ;; Your init file should contain only one such instance.
> >>  ;; If there is more than one, they won't work right.
> >>  '(default ((t (:family "Source Code Pro Medium" :foundry "outline"
> >> :slant normal :weight medium :height 90 :width normal))))
> >>  '(fixed-pitch ((t (:inherity default)))))
> >> 
> >> Emacs from master (3e23494394) ignores these settings and starts with
> >> Arial which looks likte this:
> >
> > If you revert commit 32086ea23, does the problem go away?
> 
> Yes, it does.  I did
> 
>   git checkout a491b73c765adde894acdbafc6fd97edd4343c2c
> 
> and built again.  Font settings are respected.

I think I figured it out.  It seems to be a cockpit error: the
"Medium" part is not part of the :family, and you already say
":weight medium" in the attributes anyway.  Try this instead:

 '(default ((t (:family "Source Code Pro" :foundry "outline" :slant normal :weight medium :height 90 :width normal))))

With this, I get the same results as with an older Emacs.  It is true
that the older Emacs also accepted "Source Code Pro Medium" as the
family, but the result was that it loaded the same font as the master
branch without "Medium".

Does this resolve your issue?

bug#51768: 29.0.50; User font settings are ignored (Win10)

[Arash Esbati]

Eli Zaretskii <eliz@gnu.org> writes:

> Where did you download this font, and which files exactly did you
> download for it?

The fonts are from Github.  I'm using Roman fonts version 2.030 and
Italic fonts version 1.050[1].  This is the package I fetched[2].  And
these are the fonts installed under /c/Windows/Fonts:

-> ll SourceCodePro-*
207K 19. Jul 2016  SourceCodePro-Black.ttf
171K 19. Jul 2016  SourceCodePro-BlackIt.ttf
207K 19. Jul 2016  SourceCodePro-Bold.ttf
171K 19. Jul 2016  SourceCodePro-BoldIt.ttf
209K 19. Jul 2016  SourceCodePro-ExtraLight.ttf
172K 19. Jul 2016  SourceCodePro-ExtraLightIt.ttf
177K 19. Jul 2016  SourceCodePro-It.ttf
209K 19. Jul 2016  SourceCodePro-Light.ttf
172K 19. Jul 2016  SourceCodePro-LightIt.ttf
208K 19. Jul 2016  SourceCodePro-Medium.ttf
172K 19. Jul 2016  SourceCodePro-MediumIt.ttf
208K 19. Jul 2016  SourceCodePro-Regular.ttf
208K 19. Jul 2016  SourceCodePro-Semibold.ttf
171K 19. Jul 2016  SourceCodePro-SemiboldIt.ttf

Best, Arash

Footnotes:
[1]  https://github.com/adobe-fonts/source-code-pro/releases/tag/2.030R-ro%2F1.050R-it

[2]  https://github.com/adobe-fonts/source-code-pro/releases/download/2.030R-ro%2F1.050R-it/source-code-pro-2.030R-ro-1.050R-it.zip

bug#51768: 29.0.50; User font settings are ignored (Win10)

[Arash Esbati]

[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> I think I figured it out.  It seems to be a cockpit error: the
> "Medium" part is not part of the :family, and you already say
> ":weight medium" in the attributes anyway.  Try this instead:
>
>  '(default ((t (:family "Source Code Pro" :foundry "outline" :slant
> normal :weight medium :height 90 :width normal))))
>
> With this, I get the same results as with an older Emacs.  It is true
> that the older Emacs also accepted "Source Code Pro Medium" as the
> family, but the result was that it loaded the same font as the master
> branch without "Medium".
>
> Does this resolve your issue?

No, it doesn't.  I updated my local git repo and built a fresh Emacs.
I'm comparing New (6c9ac53249) with Old (41b1fa05c7).

With  '(default ((t (:family "Source Code Pro Medium" :foundry "outline" :slant normal :weight medium :height 90 :width normal))))

- Old uses Source Code Pro Medium font (good)
- New uses Arial (bad)

 With '(default ((t (:family "Source Code Pro" :foundry "outline" :slant normal :weight medium :height 90 :width normal))))

- Old uses Source Code Regular font (bad)
- New uses Source Code Regular font (bad)

I'm attaching two snapshots where you can hopefully see the difference.
This is the medium font:

[-- Attachment #2: medium.png --]
[-- Type: image/png, Size: 2535 bytes --]

[-- Attachment #3: Type: text/plain, Size: 26 bytes --]

This is the regular font:

[-- Attachment #4: regular.png --]
[-- Type: image/png, Size: 2627 bytes --]

[-- Attachment #5: Type: text/plain, Size: 13 bytes --]


Best, Arash

bug#51768: 29.0.50; User font settings are ignored (Win10)

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Cc: 51768@debbugs.gnu.org
> Date: Thu, 11 Nov 2021 21:49:25 +0100
> 
> 
> [1:text/plain Hide]
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I think I figured it out.  It seems to be a cockpit error: the
> > "Medium" part is not part of the :family, and you already say
> > ":weight medium" in the attributes anyway.  Try this instead:
> >
> >  '(default ((t (:family "Source Code Pro" :foundry "outline" :slant
> > normal :weight medium :height 90 :width normal))))
> >
> > With this, I get the same results as with an older Emacs.  It is true
> > that the older Emacs also accepted "Source Code Pro Medium" as the
> > family, but the result was that it loaded the same font as the master
> > branch without "Medium".
> >
> > Does this resolve your issue?
> 
> No, it doesn't.  I updated my local git repo and built a fresh Emacs.
> I'm comparing New (6c9ac53249) with Old (41b1fa05c7).
> 
> With  '(default ((t (:family "Source Code Pro Medium" :foundry "outline" :slant normal :weight medium :height 90 :width normal))))
> 
> - Old uses Source Code Pro Medium font (good)
> - New uses Arial (bad)
> 
>  With '(default ((t (:family "Source Code Pro" :foundry "outline" :slant normal :weight medium :height 90 :width normal))))
> 
> - Old uses Source Code Regular font (bad)
> - New uses Source Code Regular font (bad)

Should be fixed now.

bug#51768: 29.0.50; User font settings are ignored (Win10)

[Arash Esbati]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Arash Esbati <arash@gnu.org>
>> Cc: 51768@debbugs.gnu.org
>> Date: Thu, 11 Nov 2021 21:49:25 +0100
>> 
>> 
>> [1:text/plain Hide]
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> > I think I figured it out.  It seems to be a cockpit error: the
>> > "Medium" part is not part of the :family, and you already say
>> > ":weight medium" in the attributes anyway.  Try this instead:
>> >
>> >  '(default ((t (:family "Source Code Pro" :foundry "outline" :slant
>> > normal :weight medium :height 90 :width normal))))
>> >
>> > With this, I get the same results as with an older Emacs.  It is true
>> > that the older Emacs also accepted "Source Code Pro Medium" as the
>> > family, but the result was that it loaded the same font as the master
>> > branch without "Medium".
>> >
>> > Does this resolve your issue?
>> 
>> No, it doesn't.  I updated my local git repo and built a fresh Emacs.
>> I'm comparing New (6c9ac53249) with Old (41b1fa05c7).
>> 
>> With '(default ((t (:family "Source Code Pro Medium" :foundry
>> "outline" :slant normal :weight medium :height 90 :width normal))))
>> 
>> - Old uses Source Code Pro Medium font (good)
>> - New uses Arial (bad)
>> 
>>  With '(default ((t (:family "Source Code Pro" :foundry "outline"
>> :slant normal :weight medium :height 90 :width normal))))
>> 
>> - Old uses Source Code Regular font (bad)
>> - New uses Source Code Regular font (bad)
>
> Should be fixed now.

Yes, it's fixed.  Many thanks for the quick fix.  I'm closing this
report.

Best, Arash