unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 55768@debbugs.gnu.org, Thierry EMERY <thierryalemery@gmail.com>
Subject: bug#55768: 26.3; isearch highlighting in dired
Date: Tue, 28 Jun 2022 20:37:06 +0300	[thread overview]
Message-ID: <86tu84n0zh.fsf@mail.linkov.net> (raw)
In-Reply-To: <87y1xgn1o5.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 28 Jun 2022 19:22:18 +0200")

> In other words, this:
>
> 	;; If the following character is currently invisible,
> 	;; skip all characters with that same `invisible' property value.
> 	;; Do that over and over.
> 	(while (and (< (point) end) (invisible-p (point)))
> 	  (if (invisible-p (get-text-property (point) 'invisible))
>
> Is fine, but
>
> (eq (invisible-p (point))
>     (invisible-p (get-text-property (point) 'invisible)))
>
> is always true.

I don't see how it's always true:

1. (invisible-p (point))
   checks invisibility of both: text properties and overlays.

2. (invisible-p (get-text-property (point) 'invisible))
   checks invisibility of text properties only.

3. (invisible-p (overlay-get o 'invisible))
   checks invisibility of overlays only.

There is a need for a separate check because overlays
can be opened, whereas text properties can't.





  reply	other threads:[~2022-06-28 17:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02 15:22 bug#55768: 26.3; isearch highlighting in dired Thierry EMERY
2022-06-03  3:31 ` Lars Ingebrigtsen
2022-06-03  7:23   ` Thierry EMERY
2022-06-03  7:42     ` Thierry EMERY
2022-06-04 11:24     ` Lars Ingebrigtsen
2022-06-28 16:53       ` Juri Linkov
2022-06-28 17:22         ` Lars Ingebrigtsen
2022-06-28 17:37           ` Juri Linkov [this message]
2022-06-29  9:56             ` Lars Ingebrigtsen
2022-06-29 17:58               ` Juri Linkov
2022-06-30  9:30                 ` Lars Ingebrigtsen
2022-06-30 14:37                   ` Thierry EMERY
2022-06-30 14:56                     ` Lars Ingebrigtsen
2022-06-03  7:55   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86tu84n0zh.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=55768@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=thierryalemery@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).