From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#55768: 26.3; isearch highlighting in dired Date: Tue, 28 Jun 2022 20:37:06 +0300 Organization: LINKOV.NET Message-ID: <86tu84n0zh.fsf@mail.linkov.net> References: <87leuebeyj.fsf@gnus.org> <87mtesacyr.fsf@gnus.org> <86tu84ohjw.fsf@mail.linkov.net> <87y1xgn1o5.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32595"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 55768@debbugs.gnu.org, Thierry EMERY To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 28 19:41:06 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6FD0-0008KP-4U for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Jun 2022 19:41:06 +0200 Original-Received: from localhost ([::1]:56644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6FCy-00023N-Oe for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Jun 2022 13:41:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6FBz-00022z-Dr for bug-gnu-emacs@gnu.org; Tue, 28 Jun 2022 13:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34140) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6FBy-0002iL-Sk for bug-gnu-emacs@gnu.org; Tue, 28 Jun 2022 13:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o6FBy-0004rG-LS for bug-gnu-emacs@gnu.org; Tue, 28 Jun 2022 13:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Jun 2022 17:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55768 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55768-submit@debbugs.gnu.org id=B55768.165643795518619 (code B ref 55768); Tue, 28 Jun 2022 17:40:02 +0000 Original-Received: (at 55768) by debbugs.gnu.org; 28 Jun 2022 17:39:15 +0000 Original-Received: from localhost ([127.0.0.1]:56270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6FBD-0004qF-6O for submit@debbugs.gnu.org; Tue, 28 Jun 2022 13:39:15 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:41559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6FBA-0004q0-Sw for 55768@debbugs.gnu.org; Tue, 28 Jun 2022 13:39:13 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 3262E60007; Tue, 28 Jun 2022 17:39:04 +0000 (UTC) In-Reply-To: <87y1xgn1o5.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 28 Jun 2022 19:22:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235565 Archived-At: > In other words, this: > > ;; If the following character is currently invisible, > ;; skip all characters with that same `invisible' property value. > ;; Do that over and over. > (while (and (< (point) end) (invisible-p (point))) > (if (invisible-p (get-text-property (point) 'invisible)) > > Is fine, but > > (eq (invisible-p (point)) > (invisible-p (get-text-property (point) 'invisible))) > > is always true. I don't see how it's always true: 1. (invisible-p (point)) checks invisibility of both: text properties and overlays. 2. (invisible-p (get-text-property (point) 'invisible)) checks invisibility of text properties only. 3. (invisible-p (overlay-get o 'invisible)) checks invisibility of overlays only. There is a need for a separate check because overlays can be opened, whereas text properties can't.